-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: 28 January 2025 21:16
To: Swathi K S <redacted>
Cc: krzk@kernel.org; davem@davemloft.net; edumazet@google.com;
kuba@kernel.org; pabeni@redhat.com; conor+dt@kernel.org;
richardcochran@gmail.com; mcoquelin.stm32@gmail.com; andrew@lunn.ch;
alim.akhtar@samsung.com; linux-fsd@tesla.com; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-stm32@st-
md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-
samsung-soc@vger.kernel.org; alexandre.torgue@foss.st.com;
peppe.cavallaro@st.com; joabreu@synopsys.com; rcsekar@samsung.com;
ssiddha@tesla.com; jayati.sahu@samsung.com;
pankaj.dubey@samsung.com; ravi.patel@samsung.com;
gost.dev@samsung.com
Subject: Re: [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree
bindings

On Tue, Jan 28, 2025 at 03:55:55PM +0530, Swathi K S wrote:

quoted

Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
Ethernet YAML schema to enable the DT validation.

Signed-off-by: Pankaj Dubey <redacted>
Signed-off-by: Ravi Patel <redacted>
Signed-off-by: Swathi K S <redacted>
---
 .../devicetree/bindings/net/snps,dwmac.yaml   |  5 +-
 .../bindings/net/tesla,fsd-ethqos.yaml        | 91 +++++++++++++++++++
 2 files changed, 94 insertions(+), 2 deletions(-)  create mode 100644
Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml

b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 91e75eb3f329..2243bf48a0b7 100644

--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml

@@ -103,6 +103,7 @@ properties:
         - starfive,jh7100-dwmac
         - starfive,jh7110-dwmac
         - thead,th1520-gmac
+        - tesla,fsd-ethqos

   reg:
     minItems: 1

@@ -126,7 +127,7 @@ properties:

   clocks:
     minItems: 1
-    maxItems: 8
+    maxItems: 10
     additionalItems: true
     items:
       - description: GMAC main clock

@@ -138,7 +139,7 @@ properties:

   clock-names:
     minItems: 1
-    maxItems: 8
+    maxItems: 10
     additionalItems: true
     contains:
       enum:

diff --git
a/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
b/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
new file mode 100644
index 000000000000..579a7bd1701d

--- /dev/null
+++ b/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml

@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
+---
+$id:
+https://protect2.fireeye.com/v1/url?k=6d811f84-0c0a0abe-6d8094cb-

74fe

quoted

+4860008a-af9296512b2d412c&q=1&e=ccfde7ee-b20c-400e-ab77-

48df91b2df3c&

quoted

+u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fnet%2Ftesla%2Cfsd-

ethqos.ya

quoted

+ml%23
+$schema:
+https://protect2.fireeye.com/v1/url?k=82ab8361-e320965b-82aa082e-

74fe

quoted

+4860008a-8834d7e9197f59d4&q=1&e=ccfde7ee-b20c-400e-ab77-

48df91b2df3c&

quoted

+u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
+
+title: FSD Ethernet Quality of Service
+
+maintainers:
+  - Swathi K S [off-list ref]
+
+description:
+  Tesla ethernet devices based on dwmmac support Gigabit ethernet.
+
+allOf:
+  - $ref: snps,dwmac.yaml#
+
+properties:
+  compatible:
+    const: tesla,fsd-ethqos.yaml

Humm...

Hi Rob, 
Could you help me understand if there is anything wrong here?

-Swathi