Thread (79 messages) 79 messages, 6 authors, 2024-07-08

Re: [PATCH net-next v13 06/15] net: stmmac: dwmac-loongson: Detach GMAC-specific platform data init

From: Serge Semin <hidden>
Date: 2024-07-05 10:16:19

On Thu, Jul 04, 2024 at 04:56:41PM +0800, Yanteng Si wrote:
在 2024/7/4 00:19, Serge Semin 写道:
...
quoted
...

Seeing the discussion has started anyway, could you please find out
whether the multi-channel controller will still work if the MSI IRQs
allocation failed? Will the multi-channel-ness still work in that
case?
Based on my test results:

In this case, multi-channel controller don't work. If the MSI IRQs
allocation

failed, NIC will work in single channel.
What does "NIC will work in single channel" mean? Do the driver
(network traffic flow with a normal performance) still work even with
the plat->tx_queues_to_use and plat->rx_queues_to_use fields set to
eight? If it's then the multi-channel-ness still seems to be working
but the IRQs are delivered via the common MAC IRQ. If you get to
experience the data loss, or poor performance, or no traffic flowing
at all, then indeed the non-zero channels IRQs aren't delivered.

So the main question how did you find out that the controller work in
single channel?

I will prepare v14 according to your comments,
Ok. Thanks.

Over the past year, with everyone's help, the drive has become better and
better.

Thank you everyone. Thank you very much!
Always welcome. I am glad we are finally advancing the series further.

-Serge(y)

Thanks,

Yanteng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help