Hi Serge,

在 2024/6/5 19:30, Serge Semin 写道:

On Wed, May 29, 2024 at 06:17:22PM +0800, Yanteng Si wrote:

quoted

v13:

* Sorry, we have clarified some things in the past 10 days. I did not
  give you a clear reply to the following questions in v12, so I need
  to reply again:

  1. The current LS2K2000 also have a GMAC(and two GNET) that supports 8
     channels, so we have to reconsider the initialization of
     tx/rx_queues_to_use into probe();

  2. In v12, we disagreed on the loongson_dwmac_msi_config method, but I changed
     it based on Serge's comments(If I understand correctly):
	if (dev_of_node(&pdev->dev)) {
		ret = loongson_dwmac_dt_config(pdev, plat, &res);
	}

	if (ld->loongson_id == DWMAC_CORE_LS2K2000) {
		ret = loongson_dwmac_msi_config(pdev, plat, &res);
	} else {
		ret = loongson_dwmac_intx_config(pdev, plat, &res);
	}

  3. Our priv->dma_cap.pcs is false, so let's use PHY_INTERFACE_MODE_NA;

  4. Our GMAC does not support Delay, so let's use PHY_INTERFACE_MODE_RGMII_ID,
     the current dts is wrong, a fix patch will be sent to the LoongArch list
     later.

Others:
* Re-split a part of the patch (it seems we do this with every version);
* Copied Serge's comments into the commit message of patch;
* Fixed the stmmac_dma_operation_mode() method;
* Changed some code comments.

Thanks for the new version of the series submitted. I've received the
copy and all the currently posted comments. Alas I'll be busy on this
week to join the discussions and start reviewing the bits. I'll be
able to do that early next week. Sorry for making you and the rest of
reviewers wait.

Thanks for your reply.

Ok, I just had time to test Huacai's method.


Thanks,

Yanteng