Re: [PATCH net-next 1/9] ptp: Clarify ptp_clock_info .adjphase expects an internal servo to be used
From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-05-22 20:07:59
From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-05-22 20:07:59
On Mon, May 22, 2023 at 10:03:23AM -0700, Rahul Rameshbabu wrote:
This point makes sense to me. However, I have a concern about the case where the linuxptp servo has not had a chance to make a single frequency adjustment (0 ppb) and .adjphase/LOCKED_STABLE state is initially called/reached. After converging, the frequency will be close to the remote time's server's frequency, but that frequency will likely not be 0 ppb. If .adjfine had been called previously, the difference between the remote time server's frequency and the cached frequency in the ptp stack would likely be significantly closer. That said, do you think it makes sense to have some kind of API that gives information about the in-HW controller such as the frequency offset it operated? Or maybe in general an API in the future for introspecting the state of this in-HW servo?
The whole point of hardware vendors doing this is to hide their implementation from prying eyes. So they are not going to provide introspection at all. Thanks, Richard