Thread (24 messages) 24 messages, 3 authors, 2023-05-22

Re: [PATCH net-next 1/9] ptp: Clarify ptp_clock_info .adjphase expects an internal servo to be used

From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-05-11 02:09:44

On Wed, May 10, 2023 at 01:52:58PM -0700, Rahul Rameshbabu wrote:
+PTP hardware clock requirements for '.adjphase'
+-----------------------------------------------
+
+   The 'struct ptp_clock_info' interface has a '.adjphase' function.
+   This function has a set of requirements from the PHC in order to be
+   implemented.
+
+     * The PHC implements a servo algorithm internally that is used to
+       correct the offset passed in the '.adjphase' call.
+     * When other PTP adjustment functions are called, the PHC servo
+       algorithm is disabled,
I disagree with this part:
and the frequency prior to the '.adjphase'
+       call is restored internally in the PHC.
That seems like an arbitrary rule that doesn't make much sense.

Thanks,
Richard

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help