Re: [RFC 4/7] mfd: ocelot-spi: Change the regmap stride to reflect the real one

Hello Andrew,

On Mon, 27 Mar 2023 02:02:55 +0200
Andrew Lunn [off-list ref] wrote:

quoted

quoted

quoted

 static const struct regmap_config ocelot_spi_regmap_config = {
 	.reg_bits = 24,
-	.reg_stride = 4,
+	.reg_stride = 1,
 	.reg_shift = REGMAP_DOWNSHIFT(2),
 	.val_bits = 32,    

This does not look like a bisectable change? Or did it never work
before?  

Actually this works in all cases because of "regmap: check for
alignment on translated register addresses" in this series. Before
this series, I think using a stride of 1 would have worked too, as
any 4-byte-aligned accesses are also 1-byte aligned.  

This is the sort of think which is good to explain in the commit
message. That is the place to answer questions reviewers are likely to
ask for things which are not obvious from just the patch.

That's right, I will include this explanation in the next iteration.
Thanks for the review,

Maxime

    Andrew