Re: [RFC 4/7] mfd: ocelot-spi: Change the regmap stride to reflect the real one

From
Andrew Lunn <andrew@lunn.ch>
Date
2023-03-27 00:04:18
Also in
lkml
Reply to
Maxime Chevallier, 2023-03-24
quoted
quoted
 static const struct regmap_config ocelot_spi_regmap_config = {
 	.reg_bits = 24,
-	.reg_stride = 4,
+	.reg_stride = 1,
 	.reg_shift = REGMAP_DOWNSHIFT(2),
 	.val_bits = 32,  
This does not look like a bisectable change? Or did it never work
before?
Actually this works in all cases because of "regmap: check for alignment
on translated register addresses" in this series. Before this series,
I think using a stride of 1 would have worked too, as any 4-byte-aligned
accesses are also 1-byte aligned.
This is the sort of think which is good to explain in the commit
message. That is the place to answer questions reviewers are likely to
ask for things which are not obvious from just the patch.

    Andrew
Thread (24 messages) 24 messages, 5 authors, last reply 2023-05-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help