Re: [RFC 4/7] mfd: ocelot-spi: Change the regmap stride to reflect the real one
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-03-24 12:11:23
Also in:
lkml
On Fri, Mar 24, 2023 at 10:36:41AM +0100, Maxime Chevallier wrote:
quoted hunk ↗ jump to hunk
When used over SPI, the register addresses needs to be translated, compared to when used over MMIO. The translation consists in applying an offset with reg_base, then downshifting the registers by 2. This actually changes the register stride from 4 to 1. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- drivers/mfd/ocelot-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c index 2d1349a10ca9..107cda0544aa 100644 --- a/drivers/mfd/ocelot-spi.c +++ b/drivers/mfd/ocelot-spi.c@@ -124,7 +124,7 @@ static int ocelot_spi_initialize(struct device *dev) static const struct regmap_config ocelot_spi_regmap_config = { .reg_bits = 24, - .reg_stride = 4, + .reg_stride = 1, .reg_shift = REGMAP_DOWNSHIFT(2), .val_bits = 32,
This does not look like a bisectable change? Or did it never work before? Andrew