On Wed, Sep 14, 2022 at 5:19 PM Arınç ÜNAL [off-list ref] wrote:

On 14.09.2022 18:14, Rob Herring wrote:

quoted

On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote:

quoted

Add syscon as a constant string on the compatible property as it's required
for the SoC to work. Update the example accordingly.

It's not required. It's required to automagically create a regmap. That
can be done yourself as well. The downside to adding 'syscon' is it
requires a DT update. Maybe that's fine for this platform? I don't know.

My GB-PC2 won't boot without syscon on mt7621.dtsi. This string was
always there on the memory controller node on mt7621.dtsi.

The string was introduced because the mt7621 clock driver needs to
read some registers creating a regmap from the syscon. The bindings
were added before the clock driver was properly mainlined and at first
the clock driver was using ralink architecture dependent operations
rt_memc_* defined in
'arch/mips/include/asm/mach-ralink/ralink_regs.h'. I forgot to update
the mem controller binding when memc became a syscon so I think this
patch is correct. I also think the sample should use 'syscon' in the
node name instead of memory-controller.

Best regards,
    Sergio Paracuellos

Arınç