On 26/08/2022 07:39, Íñigo Huguet wrote:

On Fri, Aug 26, 2022 at 3:32 AM Jakub Kicinski [off-list ref] wrote:

quoted

On Thu, 25 Aug 2022 11:02:41 +0200 Íñigo Huguet wrote:

quoted

+static inline int
+efx_filter_set_ipv6_local(struct efx_filter_spec *spec, u8 proto,
+                       const struct in6_addr *host, __be16 port)

also - unclear why this is defined in the header

This is just because it's the equivalent of other already existing
similar functions in that file. I think I should keep this one
untouched for cohesion.

My preference would be to keep this in filter.h as Íñigo currently
 has it, to follow the existing pattern.  These "populate a filter
 spec" functions are really just typesafe macros.

-ed