On Fri, Aug 26, 2022 at 3:32 AM Jakub Kicinski [off-list ref] wrote:

On Thu, 25 Aug 2022 11:02:41 +0200 Íñigo Huguet wrote:

quoted

-static int efx_ptp_insert_ipv4_filter(struct efx_nic *efx, u16 port)
+static inline void efx_ptp_init_filter(struct efx_nic *efx,
+                                    struct efx_filter_spec *rxfilter)

No static inline in sources unless you actually checked and the
compiler does something stupid (pls mention it in the commit message
in that case).

OK, I will change it (I think I should read again and remember the
coding style document)

quoted

+static inline int
+efx_filter_set_ipv6_local(struct efx_filter_spec *spec, u8 proto,
+                       const struct in6_addr *host, __be16 port)

also - unclear why this is defined in the header

This is just because it's the equivalent of other already existing
similar functions in that file. I think I should keep this one
untouched for cohesion.
-- 
Íñigo Huguet