Re: [PATCH net-next 2/3] sfc: support PTP over IPv6/UDP
From: Edward Cree <ecree.xilinx@gmail.com>
Date: 2022-08-09 13:22:01
On 09/08/2022 10:20, Íñigo Huguet wrote:
quoted hunk ↗ jump to hunk
@@ -1297,28 +1299,46 @@ static void efx_ptp_remove_multicast_filters(struct efx_nic *efx) } } -static int efx_ptp_insert_ipv4_filter(struct efx_nic *efx, __be16 port) +static inline void efx_ptp_init_filter(struct efx_nic *efx, + struct efx_filter_spec *rxfilter) { - struct efx_ptp_data *ptp = efx->ptp_data; - struct efx_filter_spec rxfilter; - int rc; - - efx_filter_init_rx(&rxfilter, EFX_FILTER_PRI_REQUIRED, 0, - efx_rx_queue_index( - efx_channel_get_rx_queue(ptp->channel))); + efx_filter_init_rx(rxfilter, EFX_FILTER_PRI_REQUIRED, 0, + efx_rx_queue_index(efx_channel_get_rx_queue( + efx->ptp_data->channel)));
This indentation is misleading, it makes it look as though efx->ptp_data->channel is an argument to efx_rx_queue_index(). Please just use a local (how about struct efx_rx_queue *?). Otherwise looks good. -ed