Re: [RFC PATCH v3 8/9] can: slcan: add support to set bit time register (btr)
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Date: 2022-07-27 19:04:27
Also in:
linux-can, lkml
Hello Marc and Max, On Wed, Jul 27, 2022 at 7:33 PM Max Staudt [off-list ref] wrote:
On Wed, 27 Jul 2022 19:28:45 +0200 Dario Binacchi [off-list ref] wrote:quoted
On Wed, Jul 27, 2022 at 7:21 PM Marc Kleine-Budde [off-list ref] wrote:quoted
Ok - We avoided writing bit timing registers from user space into the hardware for all existing drivers. If there isn't a specific use case, let's skip this patch. If someone comes up with a use case we can think of a proper solution.Ok. So do I also remove the 7/9 "ethtool: add support to get/set CAN bit time register" patch ?If I may answer as well - IMHO, yes. Unless we know that BTR is something other than just a different way to express the bitrate, I'd skip it, yes. Because bitrate is already handled by other, cross-device mechanisms.
Thanks to both of you for the explanations. Regards, Dario
Max
-- Dario Binacchi Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com