Thread (123 messages) 123 messages, 7 authors, 2022-07-26

Re: [PATCH net-next v3 01/47] dt-bindings: phy: Add Lynx 10G phy binding

From: Sean Anderson <hidden>
Date: 2022-07-26 15:45:13
Also in: linux-arm-kernel, linux-devicetree, linux-phy, lkml

Hi Rob,

On 7/21/22 7:35 PM, Sean Anderson wrote:
What about

	phys = <&serdes1_lane1>;

and then under the serdes node do something like

	serdes1: phy@foo {
		...

		serdes1_lane1 {
			first-lane = <1>;

			sgmii {
				fsl,pccr = <0x8>;
				fsl,idx = <2>;
				fsl,cfg = <1>;
				fsl,proto = "sgmii";
				// or PHY_TYPE_SGMII
			};

			qsgmii {
				...
			};

			xfi {
				...
			};
		};
	};

and this way you could have something like a fsl,reserved property to
deal with not-yet-supported lanes. And this could be added piecemeal by
board configs.
Does this sound good? I would like to start working on v4 of this series,
and reworking the binding will be a big part of that. Am I heading in the
right direction? This seems to be a more common approach (e.g. mediatek,tphy).

--Sean
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help