On 7/21/22 8:51 AM, Camelia Alexandra Groza wrote:

quoted

-----Original Message-----
From: Sean Anderson <redacted>
Sent: Saturday, July 16, 2022 0:59
To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
[off-list ref]; Madalin Bucur [off-list ref];
netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>; Eric Dumazet
[off-list ref]; linux-arm-kernel@lists.infradead.org; Russell
King [off-list ref]; linux-kernel@vger.kernel.org; Sean Anderson
[off-list ref]
Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in
match data

Instead of re-matching the compatible string in order to determine the
init function, just store it in the match data. This also move the setting
of the rest of the functions into init as well. 

This last sentence can be rephrased to be clearer. Maybe something like:
The separate setup functions aren't needed anymore. Merge their content
into init as well.

You're right, this is not really clear. I will revise the wording.

--Sean

quoted

To ensure everything
compiles correctly, we move them to the bottom of the file.

Signed-off-by: Sean Anderson <redacted>

Acked-by: Camelia Groza <redacted>