Hi Sergei,

Subject: Re: [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs to struct
ravb_hw_info

Hello!

On 8/17/21 6:47 PM, Biju Das wrote:

[...]

quoted

quoted

quoted

The register for retrieving TX drop counters is present only on
R-Car
Gen3 and RZ/G2L; it is not present on R-Car Gen2.

Add the tx_drop_cntrs hw feature bit to struct ravb_hw_info, to
enable this feature specifically for R-Car Gen3 now and later extend
it to

RZ/G2L.

quoted

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2:
 * Incorporated Andrew and Sergei's review comments for making it

smaller patch

quoted

   and provided detailed description.
---
 drivers/net/ethernet/renesas/ravb.h      | 1 +
 drivers/net/ethernet/renesas/ravb_main.c | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h

b/drivers/net/ethernet/renesas/ravb.h
index 0d640dbe1eed..35fbb9f60ba8 100644

--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h

@@ -1001,6 +1001,7 @@ struct ravb_hw_info {

 	/* hardware features */
 	unsigned internal_delay:1;	/* RAVB has internal delays */
+	unsigned tx_drop_cntrs:1;	/* RAVB has TX error counters */

   I suggest 'tx_counters' -- this name comes from the sh_eth driver
for the same regs (but negated meaning). And please don't call the
hardware RAVB. :-)

Agreed. Will change it to 'tx_counters' on next version and comment it
as
/* AVB-DMAC has TX counters */

   The counters belong to E-MAC, not AVB-DMAC.

You are correct, it is at offset 0x700 on E-MAC block.

Cheers,
Biju