Thread (59 messages) 59 messages, 5 authors, 2021-08-18

RE: [PATCH net-next v2 3/8] ravb: Add num_gstat_queue to struct ravb_hw_info

From: Biju Das <biju.das.jz@bp.renesas.com>
Date: 2021-08-03 19:13:45
Also in: linux-renesas-soc

Hi Sergei,

Thanks for the feedback.
Subject: Re: [PATCH net-next v2 3/8] ravb: Add num_gstat_queue to struct
ravb_hw_info

Hello!

On 8/2/21 1:26 PM, Biju Das wrote:
quoted
The number of queues used in retrieving device stats for R-Car is 2,
whereas for RZ/G2L it is 1.
   Mhm, how many RX queues are on your platform, 1? Then we don't need so
specific name, just num_rx_queue.
There are 2 RX queues, but we provide only device stats information from first queue.

R-Car = 2x15 = 30 device stats
RZ/G2L = 1x15 = 15 device stats.

Cheers,
Biju

quoted
Add the num_gstat_queue variable to struct ravb_hw_info, to add
subsequent SoCs without any code changes to the ravb_get_ethtool_stats
function.
quoted
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
[...]

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help