Hi Sergei,

Subject: Re: [PATCH net-next v2 7/8] ravb: Add internal delay hw feature
to struct ravb_hw_info

On 04.08.2021 8:13, Biju Das wrote:

[...]

quoted

quoted

quoted

R-Car Gen3 supports TX and RX clock internal delay modes, whereas
R-Car
Gen2 and RZ/G2L do not support it.
Add an internal_delay hw feature bit to struct ravb_hw_info to
enable this only for R-Car Gen3.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2:
  * Incorporated Andrew and Sergei's review comments for making it

smaller patch

quoted

    and provided detailed description.
---
  drivers/net/ethernet/renesas/ravb.h      | 3 +++
  drivers/net/ethernet/renesas/ravb_main.c | 6 ++++--
  2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h

b/drivers/net/ethernet/renesas/ravb.h
index 3df813b2e253..0d640dbe1eed 100644

--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h

@@ -998,6 +998,9 @@ struct ravb_hw_info {
  	int num_tx_desc;
  	int stats_len;
  	size_t skb_sz;
+
+	/* hardware features */
+	unsigned internal_delay:1;	/* RAVB has internal delays */

    Oops, missed it initially:
    RAVB? That's not a device name, according to the manuals. It
seems to be the driver's name.

OK. will change it to AVB-DMAC has internal delays.

    Please don't -- E-MAC has them, not AVB-DMAC.

Since the register for setting internal delay mode is coming from product specific register(0x8c),
I am agreeing with your statement, "E-MAC has internal delays".

Cheers,
Biju