Thread (72 messages) flat view 72 messages, 7 authors, 2021-05-16

Re: [RFC PATCH net-next v4 19/28] net: dsa: qca8k: make rgmii delay configurable

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-05-09 01:28:40
Also in: lkml

And that is the intention of the port. I didn't want the binding to be
set on the switch node but on the rgmii node. Correct me if I'm wrong
but isn't what this patch already do?

In of_rgmii_delay I get the ports node of the current switch, iterate
every port, find the one with the phy-mode set to "rgmii-id"
You know this hardware only has one RGMII port, and you know which one
it is. So search the list of ports to find that one particular port,
and see if 'rgmii' is set as phy-mode and if so, what the delays are.
This is a port property, so you need to look at that specific port,
not any random port that might have rgmii set.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help