Re: [RFC PATCH net-next v4 01/28] net: mdio: ipq8064: clean whitespaces in define
From: Jonathan McDowell <hidden>
Date: 2021-05-16 09:50:07
Also in:
lkml
On Sat, May 15, 2021 at 07:30:26PM +0200, Ansuel Smith wrote:
On Sat, May 15, 2021 at 06:00:46PM +0100, Jonathan McDowell wrote:quoted
On Sat, May 08, 2021 at 08:05:58PM +0200, Ansuel Smith wrote:quoted
On Sat, May 08, 2021 at 08:02:33PM +0200, Andrew Lunn wrote:quoted
On Sat, May 08, 2021 at 02:28:51AM +0200, Ansuel Smith wrote:quoted
Fix mixed whitespace and tab for define spacing.Please add a patch [0/28] which describes the big picture of what these changes are doing. Also, this series is getting big. You might want to split it into two, One containing the cleanup, and the second adding support for the new switch. AndrewThere is a 0/28. With all the changes. Could be that I messed the cc? I agree think it's better to split this for the mdio part, the cleanup and the changes needed for the internal phy.FWIW I didn't see the 0/28 mail either. I tried these out on my RB3011 today. I currently use the GPIO MDIO driver because I saw issues with the IPQ8064 driver in the past, and sticking with the GPIO driver I see both QCA8337 devices and traffic flows as expected, so no obvious regressions from your changes. I also tried switching to the IPQ8064 MDIO driver for my first device (which is on the MDIO0 bus), but it's still not happy: qca8k 37000000.mdio-mii:10: Switch id detected 0 but expected 13Can you try the v6 version of this series?
FWIW I tried v6 without altering my DT at all (so still using the GPIO MDIO driver, and not switching to use the alternate PHY support) and got an oops due to a NULL pointer dereference, apparently in the mdio_bus locking code. I'm back porting to 5.10.37 (because I track LTS on the device) so I might be missing something, but the v4 version I tried previously worked ok. 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address 00000558 pgd = (ptrval) [00000558] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Modules linked in: CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.10.37-00045-g7d01aa2545cb #2 Hardware name: Generic DT based system Workqueue: events deferred_probe_work_func PC is at mutex_lock+0x20/0x50 LR is at _cond_resched+0x28/0x4c pc : [<c0a36b24>] lr : [<c0a34530>] psr: 60000013 sp : c1569c38 ip : 00000001 fp : c17bd1dc r10: c17bd1c0 r9 : 00000000 r8 : 00000000 r7 : 00000002 r6 : 00000558 r5 : 00000000 r4 : 00000558 r3 : c1560000 r2 : c0e54389 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c5787d Table: 4220406a DAC: 00000051 Process kworker/0:1 (pid: 20, stack limit = 0x(ptrval)) Stack: (0xc1569c38 to 0xc156a000) 9c20: c8020000 c07ee9b8 9c40: c17cc000 c17cc000 00000001 c07eea54 c17cc000 c07e25b8 c1569d14 c06d0f14 9c60: 00000000 30353630 ffff0a00 c17cc558 c17cc000 00000001 00000002 00000000 9c80: 00000000 c17bd1c0 c17bd1dc c07e2810 c0f04cc8 c17cc000 00000001 c0f04cc8 9ca0: 00000000 c07df518 ffffff08 ffff0a00 c0f0517c 00000000 00000000 ffffffff 9cc0: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff 9ce0: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff 9d00: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff 9d20: ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff 58cdc110 9d40: c17cc578 c0f04cc8 c17cc000 c17cc000 00000001 c17cc578 00000000 c17bd1c0 9d60: c17bd1dc c07e20a0 00000000 c17bd1c0 c17bd1dc 58cdc110 00000001 c17cc000 9d80: 00000001 c17cc008 c17cc578 00000000 c17bd1c0 c07e29a4 c17bc040 00000000 9da0: c17bc040 c17d2800 c17bd0cc 00000001 c17bd1c0 c0a11814 00000000 00000dc0 9dc0: c0b81b20 c0f04cc8 c17bd1dc c0ceca94 c0d6e2b4 c17bd1c0 00000005 c17d2640 9de0: 00000040 c177c400 00000000 c0fe8b08 c17bc000 00000040 c177c400 00000000 9e00: 00000000 58cdc110 c0b59f78 c0fc4e44 c177c400 c102f58c 00000000 c0fe8b08 9e20: c0fc4e44 00000001 00000000 c07e2d04 c177c400 c102f584 c102f58c c0755e50 9e40: 60000013 58cdc110 c0d2b58c c177c400 c0fc4e44 c1569ecc c0fe8b08 00000001 9e60: c0d2b58c c0fe8b08 ffffe000 c0756400 c177c400 00000001 00000001 00000000 9e80: c0f04cc8 c1569ecc c0756664 00000001 c0d2b58c c0fe8b08 ffffe000 c0754028 9ea0: c0d2b58c c15aac6c c17808b8 58cdc110 c177c400 c177c400 c0f04cc8 c177c444 9ec0: c0fba314 c0755ca8 00000002 c177c400 00000001 58cdc110 c177c400 c177c400 9ee0: c0fc21f4 c0fba314 c0fe8b08 c0754dac c177c400 c0fba300 c0fba300 c075530c 9f00: c0fba340 c1403f00 df6917c0 df694900 00000000 c0fdf300 00000000 c033c034 9f20: c1560000 df6917c0 00000008 c1403f00 c1403f14 df6917c0 00000008 c0f03d00 9f40: df6917d8 df6917c0 ffffe000 c033c3cc c1560000 c0fdeb1e c0cdfe28 c033c388 9f60: c1403f00 c14e6040 c1549280 00000000 c1568000 c033c388 c1403f00 c14bdea4 9f80: c14e6064 c034282c 00000001 c1549280 c03426dc 00000000 00000000 00000000 9fa0: 00000000 00000000 00000000 c0300148 00000000 00000000 00000000 00000000 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [<c0a36b24>] (mutex_lock) from [<c07ee9b8>] (qca8k_mdio_read+0x30/0xac) [<c07ee9b8>] (qca8k_mdio_read) from [<c07eea54>] (qca8k_phy_read+0x20/0x30) [<c07eea54>] (qca8k_phy_read) from [<c07e25b8>] (__mdiobus_read+0x3c/0x1ac) [<c07e25b8>] (__mdiobus_read) from [<c07e2810>] (mdiobus_read+0x30/0x44) [<c07e2810>] (mdiobus_read) from [<c07df518>] (get_phy_device+0x13c/0x25c) [<c07df518>] (get_phy_device) from [<c07e20a0>] (mdiobus_scan+0xb0/0x190) [<c07e20a0>] (mdiobus_scan) from [<c07e29a4>] (__mdiobus_register+0x17c/0x2fc) [<c07e29a4>] (__mdiobus_register) from [<c0a11814>] (dsa_register_switch+0xbb8/0xc6c) [<c0a11814>] (dsa_register_switch) from [<c07e2d04>] (mdio_probe+0x2c/0x50) [<c07e2d04>] (mdio_probe) from [<c0755e50>] (really_probe+0x108/0x4f4) [<c0755e50>] (really_probe) from [<c0756400>] (driver_probe_device+0x78/0x1e4) [<c0756400>] (driver_probe_device) from [<c0754028>] (bus_for_each_drv+0x80/0xc4) [<c0754028>] (bus_for_each_drv) from [<c0755ca8>] (__device_attach+0xe0/0x178) [<c0755ca8>] (__device_attach) from [<c0754dac>] (bus_probe_device+0x84/0x8c) [<c0754dac>] (bus_probe_device) from [<c075530c>] (deferred_probe_work_func+0x9c/0xdc) [<c075530c>] (deferred_probe_work_func) from [<c033c034>] (process_one_work+0x22c/0x580) [<c033c034>] (process_one_work) from [<c033c3cc>] (worker_thread+0x44/0x5c8) [<c033c3cc>] (worker_thread) from [<c034282c>] (kthread+0x150/0x154) [<c034282c>] (kthread) from [<c0300148>] (ret_from_fork+0x14/0x2c) Exception stack(0xc1569fb0 to 0xc1569ff8) 9fa0: 00000000 00000000 00000000 00000000 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 Code: e3c33d7f e3c3303f e593300c f594f000 (e1941f9f) ---[ end trace cc9433437c472cd4 ]--- J. -- 101 things you can't have too much of : 42 - Pepsi. This .sig brought to you by the letter P and the number 1 Product of the Republic of HuggieTag