Re: [PATCH net-next 4/7] net: phy: marvell10g: add MACTYPE definitions for 88X3310/88X3310P
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2021-03-24 18:12:54
On Wed, Mar 24, 2021 at 06:09:09PM +0000, Marek Behún wrote:
On Wed, 24 Mar 2021 16:58:36 +0000 Russell King - ARM Linux admin [off-list ref] wrote:quoted
On Wed, Mar 24, 2021 at 05:50:20PM +0100, Marek Behún wrote:quoted
Add all MACTYPE definitions for 88X3310/88X3310P. In order to have consistent naming, rename MV_V2_PORT_CTRL_MACTYPE_RATE_MATCH to MV_V2_PORT_CTRL_MACTYPE_10GR_RATE_MATCH.We probably ought to note that the 88x3310 and 88x3340 will be detected by this driver, but have different MACTYPE definitions.Is 88X3340 supported? The drivers structure only defines for .phy_id = MARVELL_PHY_ID_88X3310 Do 88X3310 and 3340 have the same PHY_ID ?
Yes they do. I believe they can be distinguished by bit 3, conventionally part of the PHY revision. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!