Re: [PATCH net-next 4/7] net: phy: marvell10g: add MACTYPE definitions for 88X3310/88X3310P
From: Marek Behún <kabel@kernel.org>
Date: 2021-03-24 17:10:43
On Wed, 24 Mar 2021 16:58:36 +0000 Russell King - ARM Linux admin [off-list ref] wrote:
On Wed, Mar 24, 2021 at 05:50:20PM +0100, Marek Behún wrote:quoted
Add all MACTYPE definitions for 88X3310/88X3310P. In order to have consistent naming, rename MV_V2_PORT_CTRL_MACTYPE_RATE_MATCH to MV_V2_PORT_CTRL_MACTYPE_10GR_RATE_MATCH.We probably ought to note that the 88x3310 and 88x3340 will be detected by this driver, but have different MACTYPE definitions.
Is 88X3340 supported? The drivers structure only defines for .phy_id = MARVELL_PHY_ID_88X3310 Do 88X3310 and 3340 have the same PHY_ID ? Also these registers are different for 88E2110, and the register which contains MACTYPE has a different address. Yes, I want to do this, but in another series, because I don't have the board with 88E2210 now. Marek