Thread (13 messages) flat view 13 messages, 2 authors, 2021-03-24

Re: [PATCH net-next 5/7] net: phy: marvell10g: save MACTYPE instead of rate_matching boolean

From: Marek Behún <kabel@kernel.org>
Date: 2021-03-24 17:12:55

On Wed, 24 Mar 2021 16:59:46 +0000
Russell King - ARM Linux admin [off-list ref] wrote:
On Wed, Mar 24, 2021 at 05:50:21PM +0100, Marek Behún wrote:
quoted
Save MACTYPE instead of rate_matching boolean. We will need this for
other configurations.  
This could lead us to having to test for multiple different mactype
values depending on the PHY type in mv3310_update_interface() which
is something I wanted to avoid.
This is currently done in patches 6/7 and 7/7...

Either we do this this way, or we save both members
  bool rate_matching;
  phy_interface_t interface10g;
in order not to do this always in mv3310_update_interface().

I guess I am going to change it.

Marek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help