Re: [PATCH 07/17] octeontx2-pf: Add packet transmission support

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master linus/master v5.5-rc5 next-20200110]
[cannot apply to ipvs/master sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/octeontx2-pf-Add-network-driver-for-physical-function/20200111-050500
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e267371dd376d1b3ebc9f01229845a9656734d97
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:15:0:
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_write64':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:210:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
     writeq(val, addr);
     ^~~~~~
     writel
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_read64':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:217:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
     return readq(addr);
            ^~~~~
            readl
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_snd_pkt_handler':

quoted

drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:96:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

     skb = (struct sk_buff *)sg->skb;
           ^

quoted

drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:104:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

     sg->skb = (u64)NULL;
               ^
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_sqe_add_sg':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:392:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     sq->sg[sq->head].skb = (u64)skb;
                            ^
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c: In function 'otx2_cleanup_tx_cqes':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:534:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      skb = (struct sk_buff *)sg->skb;
            ^
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:538:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       sg->skb = (u64)NULL;
                 ^
   cc1: some warnings being treated as errors

vim +96 drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c

    75	
    76	static void otx2_snd_pkt_handler(struct otx2_nic *pfvf,
    77					 struct otx2_cq_queue *cq,
    78					 struct otx2_snd_queue *sq,
    79					 struct nix_cqe_tx_s *cqe,
    80					 int budget, int *tx_pkts, int *tx_bytes)
    81	{
    82		struct nix_send_comp_s *snd_comp = &cqe->comp;
    83		struct sk_buff *skb = NULL;
    84		struct sg_list *sg;
    85	
    86		if (unlikely(snd_comp->status)) {
    87			netdev_info(pfvf->netdev,
    88				    "TX%d: Error in send CQ status:%x\n",
    89				    cq->cint_idx, snd_comp->status);
    90		}
    91	
    92		/* Barrier, so that update to sq by other cpus is visible */
    93		smp_mb();
    94		sg = &sq->sg[snd_comp->sqe_id];
    95	
  > 96		skb = (struct sk_buff *)sg->skb;
    97		if (unlikely(!skb))
    98			return;
    99	
   100		*tx_bytes += skb->len;
   101		(*tx_pkts)++;
   102		otx2_dma_unmap_skb_frags(pfvf, sg);
   103		napi_consume_skb(skb, budget);
 > 104		sg->skb = (u64)NULL;
   105	}
   106	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation