Re: [PATCH 01/17] octeontx2-pf: Add Marvell OcteonTX2 NIC driver

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master linus/master v5.5-rc5 next-20200110]
[cannot apply to ipvs/master sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/octeontx2-pf-Add-network-driver-for-physical-function/20200111-050500
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e267371dd376d1b3ebc9f01229845a9656734d97
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/af/mbox.c: In function 'otx2_mbox_msg_send':

quoted

drivers/net/ethernet/marvell/octeontx2/af/mbox.c:207:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]

     writeq(1, (void __iomem *)mbox->reg_base +
     ^~~~~~
     writel
   cc1: some warnings being treated as errors
--
   In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:20:0:
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_write64':

quoted

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:67:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]

     writeq(val, addr);
     ^~~~~~
     writel
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_read64':

quoted

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:74:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]

     return readq(addr);
            ^~~~~
            readl
   cc1: some warnings being treated as errors

vim +67 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h

    62	
    63	static inline void otx2_write64(struct otx2_nic *nic, u64 offset, u64 val)
    64	{
    65		void __iomem *addr = otx2_get_regaddr(nic, offset);
    66	
  > 67		writeq(val, addr);
    68	}
    69	
    70	static inline u64 otx2_read64(struct otx2_nic *nic, u64 offset)
    71	{
    72		void __iomem *addr = otx2_get_regaddr(nic, offset);
    73	
  > 74		return readq(addr);
    75	}
    76	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation