Re: [PATCH 04/17] octeontx2-pf: Initialize and config queues

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master linus/master v5.5-rc5 next-20200110]
[cannot apply to ipvs/master sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/sunil-kovvuri-gmail-com/octeontx2-pf-Add-network-driver-for-physical-function/20200111-050500
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e267371dd376d1b3ebc9f01229845a9656734d97
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:15:0:
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_write64':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:124:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
     writeq(val, addr);
     ^~~~~~
     writel
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_read64':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:131:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
     return readq(addr);
            ^~~~~
            readl
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_sq_init':

quoted

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:285:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

     sq->io_addr = (__force u64)otx2_get_regaddr(pfvf, NIX_LF_OP_SENDX(0));
                   ^
   cc1: some warnings being treated as errors

vim +285 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c

   260	
   261	static int otx2_sq_init(struct otx2_nic *pfvf, u16 qidx, u16 sqb_aura)
   262	{
   263		struct otx2_qset *qset = &pfvf->qset;
   264		struct otx2_snd_queue *sq;
   265		struct nix_aq_enq_req *aq;
   266		struct otx2_pool *pool;
   267		int err;
   268	
   269		pool = &pfvf->qset.pool[sqb_aura];
   270		sq = &qset->sq[qidx];
   271		sq->sqe_size = NIX_SQESZ_W16 ? 64 : 128;
   272		sq->sqe_cnt = qset->sqe_cnt;
   273	
   274		err = qmem_alloc(pfvf->dev, &sq->sqe, 1, sq->sqe_size);
   275		if (err)
   276			return err;
   277	
   278		sq->sqe_base = sq->sqe->base;
   279	
   280		sq->sqe_per_sqb = (pfvf->hw.sqb_size / sq->sqe_size) - 1;
   281		sq->num_sqbs = (qset->sqe_cnt + sq->sqe_per_sqb) / sq->sqe_per_sqb;
   282		sq->aura_id = sqb_aura;
   283		sq->aura_fc_addr = pool->fc_addr->base;
   284		sq->lmt_addr = (__force u64 *)(pfvf->reg_base + LMT_LF_LMTLINEX(qidx));
 > 285		sq->io_addr = (__force u64)otx2_get_regaddr(pfvf, NIX_LF_OP_SENDX(0));
   286	
   287		/* Get memory to put this msg */
   288		aq = otx2_mbox_alloc_msg_nix_aq_enq(&pfvf->mbox);
   289		if (!aq)
   290			return -ENOMEM;
   291	
   292		aq->sq.cq = pfvf->hw.rx_queues + qidx;
   293		aq->sq.max_sqe_size = NIX_MAXSQESZ_W16; /* 128 byte */
   294		aq->sq.cq_ena = 1;
   295		aq->sq.ena = 1;
   296		/* Only one SMQ is allocated, map all SQ's to that SMQ  */
   297		aq->sq.smq = pfvf->hw.txschq_list[NIX_TXSCH_LVL_SMQ][0];
   298		aq->sq.smq_rr_quantum = DFLT_RR_QTM;
   299		aq->sq.default_chan = pfvf->hw.tx_chan_base;
   300		aq->sq.sqe_stype = NIX_STYPE_STF; /* Cache SQB */
   301		aq->sq.sqb_aura = sqb_aura;
   302		/* Due pipelining impact minimum 2000 unused SQ CQE's
   303		 * need to maintain to avoid CQ overflow.
   304		 */
   305		aq->sq.cq_limit = ((SEND_CQ_SKID * 256) / (sq->sqe_cnt));
   306	
   307		/* Fill AQ info */
   308		aq->qidx = qidx;
   309		aq->ctype = NIX_AQ_CTYPE_SQ;
   310		aq->op = NIX_AQ_INSTOP_INIT;
   311	
   312		return otx2_sync_mbox_msg(&pfvf->mbox);
   313	}
   314	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation