Re: [PATCH 14/17] octeontx2-pf: Add basic ethtool support
From: Jakub Kicinski <hidden>
Date: 2020-01-10 19:28:24
On Fri, 10 Jan 2020 17:11:58 +0530, sunil.kovvuri@gmail.com wrote:
+static const struct otx2_stat otx2_dev_stats[] = {
+ OTX2_DEV_STAT(rx_bytes),
+ OTX2_DEV_STAT(rx_frames),
+ OTX2_DEV_STAT(rx_ucast_frames),
+ OTX2_DEV_STAT(rx_bcast_frames),
+ OTX2_DEV_STAT(rx_mcast_frames),
+ OTX2_DEV_STAT(rx_drops),
+
+ OTX2_DEV_STAT(tx_bytes),
+ OTX2_DEV_STAT(tx_frames),
+ OTX2_DEV_STAT(tx_ucast_frames),
+ OTX2_DEV_STAT(tx_bcast_frames),
+ OTX2_DEV_STAT(tx_mcast_frames),
+ OTX2_DEV_STAT(tx_drops),
+};Please don't duplicate the same exact stats which are exposed via ndo_get_stats64 via ethtool.