Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'
From: David Miller <davem@davemloft.net>
Date: 2020-01-09 01:55:05
From: Matthew Wilcox <willy@infradead.org> Date: Wed, 8 Jan 2020 17:03:44 -0800
On Wed, Jan 08, 2020 at 03:05:49PM -0800, David Miller wrote:quoted
From: Matthew Wilcox <willy@infradead.org> Date: Wed, 8 Jan 2020 13:59:29 -0800quoted
This waas a mistaken version; please revert and apply v3 instead.Are you sure? [davem@localhost net-next]$ git show e102774588b3ac0d221ed2d03a5153e056f1354f >x.diff [davem@localhost net-next]$ patch -p1 -R <x.diff patching file drivers/net/ethernet/3com/3c59x.c [davem@localhost net-next]$ mv ~/Downloads/V3-net-3com-3c59x-remove-set-but-not-used-variable-mii_reg1.patch ./ [davem@localhost net-next]$ patch -p1 <V3-net-3com-3c59x-remove-set-but-not-used-variable-mii_reg1.patch patching file drivers/net/ethernet/3com/3c59x.c [davem@localhost net-next]$ git diff [davem@localhost net-next]$ There is no difference in the code of the commit at all between V2 and V3.v2: - mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR); v3: - mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR); + mdio_read(dev, vp->phys[0], MII_BMSR);
Then check what is in the GIT tree I probably applied V3 and replied accidently to V2 :-)