Thread (9 messages) 9 messages, 4 authors, 2020-01-09

Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'

From: yukuai (C) <hidden>
Date: 2020-01-06 14:21:44


On 2020/1/6 21:13, Michal Kubecek wrote:
quoted
@@ -1605,7 +1605,6 @@ vortex_up(struct net_device *dev)
  	window_write32(vp, config, 3, Wn3_Config);
  
  	if (dev->if_port == XCVR_MII || dev->if_port == XCVR_NWAY) {
-		mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR);
  		mdio_read(dev, vp->phys[0], MII_LPA);
  		vp->partner_flow_ctrl = ((mii_reg5 & 0x0400) != 0);
  		vp->mii.full_duplex = vp->full_duplex;
Here you removed the read, as you did in previous version of the patch.
Sorry about the stupit mistake.

Yu Kuai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help