Thread (9 messages) 9 messages, 4 authors, 2020-01-09

Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'

From: Matthew Wilcox <willy@infradead.org>
Date: 2020-01-08 21:59:42

On Wed, Jan 08, 2020 at 12:40:21PM -0800, David Miller wrote:
From: yu kuai <redacted>
Date: Mon, 6 Jan 2020 20:53:37 +0800
quoted
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/3com/3c59x.c: In function ‘vortex_up’:
drivers/net/ethernet/3com/3c59x.c:1551:9: warning: variable
‘mii_reg1’ set but not used [-Wunused-but-set-variable]

It is never used, and so can be removed.

Signed-off-by: yu kuai <redacted>
---
changes in V2
-The read might have side effects, don't remove it.
Applied to net-next, thank you.
This waas a mistaken version; please revert and apply v3 instead.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help