Re: [PATCH V2] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'
From: Michal Kubecek <hidden>
Date: 2020-01-06 13:13:33
On Mon, Jan 06, 2020 at 08:53:37PM +0800, yu kuai wrote:
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/3com/3c59x.c: In function ‘vortex_up’: drivers/net/ethernet/3com/3c59x.c:1551:9: warning: variable ‘mii_reg1’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai <redacted> --- changes in V2 -The read might have side effects, don't remove it.
[...]
quoted hunk ↗ jump to hunk
@@ -1605,7 +1605,6 @@ vortex_up(struct net_device *dev) window_write32(vp, config, 3, Wn3_Config); if (dev->if_port == XCVR_MII || dev->if_port == XCVR_NWAY) { - mii_reg1 = mdio_read(dev, vp->phys[0], MII_BMSR); mdio_read(dev, vp->phys[0], MII_LPA); vp->partner_flow_ctrl = ((mii_reg5 & 0x0400) != 0); vp->mii.full_duplex = vp->full_duplex;
Here you removed the read, as you did in previous version of the patch. Michal Kubecek