RE: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via tc-taprio offload

Hi David,

Thanks!
Br,
Po Liu

-----Original Message-----
From: David Miller <davem@davemloft.net>
Sent: 2019年11月13日 3:00
To: simon.horman@netronome.com
Cc: Po Liu <redacted>; Claudiu Manoil <claudiu.manoil@nxp.com>;
linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
vinicius.gomes@intel.com; Vladimir Oltean [off-list ref];
Alexandru Marginean [off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
tc-taprio offload

Caution: EXT Email

From: David Miller <davem@davemloft.net>
Date: Tue, 12 Nov 2019 10:58:59 -0800 (PST)

quoted

Oops, I didn't see this feedback because v2 had been posted.

I'll revert that now.

Please address Simon's feedback on these two patches, and then post a
v3, thank you.

Also, v2 doesn't even compile :-(

In file included from drivers/net/ethernet/freescale/enetc/enetc.h:14,
                 from drivers/net/ethernet/freescale/enetc/enetc_qos.c:4:
drivers/net/ethernet/freescale/enetc/enetc_qos.c: In function
ʽenetc_setup_tc_taprioʼ:
drivers/net/ethernet/freescale/enetc/enetc_hw.h:308:32: warning: ʽtempʼ may
be used uninitialized in this function [-Wmaybe-uninitialized]  #define
enetc_wr_reg(reg, val) iowrite32((val), (reg))
                                ^~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc_qos.c:59:6: note: ʽtempʼ was
declared here

More delete one line. Will fix in v3.

  u32 temp;
      ^~~~
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-
enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-
enetc-vf.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1282: modules] Error 2

I got this situation. 
It happened when set module mode, since vf drvier should not own the taprio set.
Thanks!