ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Singed-off-by: Vladimir Oltean [off-list ref]
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 2 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
6 files changed, 285 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -440,22 +447,6 @@ union enetc_rx_bd {#define EMETC_MAC_ADDR_FILT_RES 3 /* # of reserved entries at the beginning */#define ENETC_MAX_NUM_VFS 2-structenetc_cbd{-union{-struct{-__le32addr[2];-__le32opt[4];-};-__le32data[6];-};-__le16index;-__le16length;-u8cmd;-u8cls;-u8_res;-u8status_flags;-};-#define ENETC_CBD_FLAGS_SF BIT(7) /* short format */#define ENETC_CBD_STATUS_MASK 0xf
@@ -554,3 +545,130 @@ static inline void enetc_set_bdr_prio(struct enetc_hw *hw, int bdr_idx,val|=ENETC_TBMR_SET_PRIO(prio);enetc_txbdr_wr(hw,bdr_idx,ENETC_TBMR,val);}++enumbdcr_cmd_class{+BDCR_CMD_UNSPEC=0,+BDCR_CMD_MAC_FILTER,+BDCR_CMD_VLAN_FILTER,+BDCR_CMD_RSS,+BDCR_CMD_RFS,+BDCR_CMD_PORT_GCL,+BDCR_CMD_RECV_CLASSIFIER,+__BDCR_CMD_MAX_LEN,+BDCR_CMD_MAX_LEN=__BDCR_CMD_MAX_LEN-1,+};++/* class 5, command 0 */+structtgs_gcl_conf{+u8atc;/* init gate value */+u8res[7];+union{+struct{+u8res1[4];+__le16acl_len;+u8res2[2];+};+struct{+u32cctl;+u32ccth;+};+};+};++#define ENETC_CBDR_SGL_IOMEN BIT(0)+#define ENETC_CBDR_SGL_IPVEN BIT(3)+#define ENETC_CBDR_SGL_GTST BIT(4)+#define ENETC_CBDR_SGL_IPV_MASK 0xe++/* gate control list entry */+structgce{+u32period;+u8gate;+u8res[3];+};++/* tgs_gcl_conf address point to this data space */+structtgs_gcl_data{+u32btl;+u32bth;+u32ct;+u32cte;+};++/* class 5, command 1 */+structtgs_gcl_query{+u8res[12];+union{+struct{+__le16acl_len;/* admin list length */+__le16ocl_len;/* operation list length */+};+struct{+u16admin_list_len;+u16oper_list_len;+};+};+};++/* tgs_gcl_query command response data format */+structtgs_gcl_resp{+u32abtl;/* base time */+u32abth;+u32act;/* cycle time */+u32acte;/* cycle time extend */+u32cctl;/* config change time */+u32ccth;+u32obtl;/* operation base time */+u32obth;+u32oct;/* operation cycle time */+u32octe;/* operation cycle time extend */+u32ccel;/* config change error */+u32cceh;+};++structenetc_cbd{+union{+struct{+__le32addr[2];+union{+__le32opt[4];+structtgs_gcl_confgcl_conf;+structtgs_gcl_querygcl_query;+};+};/* Long format */+__le32data[6];+};+__le16index;+__le16length;+u8cmd;+u8cls;+u8_res;+u8status_flags;+};++#define ENETC_PTCFPR(n) (0x1910 + (n) * 4) /* n = [0 ..7] */+#define ENETC_FPE BIT(31)++/* Port capability register 0 */+#define ENETC_PCAPR0_PSFPM BIT(10)+#define ENETC_PCAPR0_PSFP BIT(9)+#define ENETC_PCAPR0_TSN BIT(4)+#define ENETC_PCAPR0_QBU BIT(3)++/* port time gating control register */+#define ENETC_QBV_PTGCR_OFFSET 0x11a00+#define ENETC_QBV_TGE 0x80000000+#define ENETC_QBV_TGPE BIT(30)+#define ENETC_QBV_TGDROP_DISABLE BIT(29)++/* Port time gating capability register */+#define ENETC_QBV_PTGCAPR_OFFSET 0x11a08+#define ENETC_QBV_MAX_GCL_LEN_MASK 0xffff++/* Port time gating admin gate list status register */+#define ENETC_QBV_PTGAGLSR_OFFSET 0x11a10+#define ENETC_QBV_CFG_PEND_MASK 0x00000002++#define ENETC_TGLSTR 0xa200+#define ENETC_TGS_MIN_DIS_MASK 0x80000000+#define ENETC_MIN_LOOKAHEAD_MASK 0xffff
@@ -0,0 +1,130 @@+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)+/* Copyright 2019 NXP */++#include"enetc.h"++#include<net/pkt_sched.h>++staticu16enetc_get_max_gcl_len(structenetc_hw*hw)+{+returnenetc_rd(hw,ENETC_QBV_PTGCAPR_OFFSET)+&ENETC_QBV_MAX_GCL_LEN_MASK;+}++staticintenetc_setup_taprio(structnet_device*ndev,+structtc_taprio_qopt_offload*admin_conf)+{+structenetc_ndev_priv*priv=netdev_priv(ndev);+structenetc_cbdcbd={.cmd=0};+structtgs_gcl_conf*gcl_config;+structtgs_gcl_data*gcl_data;+structgce*gce;+dma_addr_tdma;+u16data_size;+u16gcl_len;+u32temp;+inti;++gcl_len=admin_conf->num_entries;+if(gcl_len>enetc_get_max_gcl_len(&priv->si->hw))+return-EINVAL;++if(admin_conf->enable){+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+usleep_range(10,20);+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp|ENETC_QBV_TGE);+}else{+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+return0;+}++/* Configure the (administrative) gate control list using the+*controlBDdescriptor.+*/+gcl_config=&cbd.gcl_conf;++data_size=sizeof(structtgs_gcl_data)+gcl_len*sizeof(structgce);++gcl_data=kzalloc(data_size,__GFP_DMA|GFP_KERNEL);+if(!gcl_data)+return-ENOMEM;++gce=(structgce*)(gcl_data+1);++/* Since no initial state config in taprio, set gates open as default.+*/+gcl_config->atc=0xff;+gcl_config->acl_len=cpu_to_le16(gcl_len);++if(!admin_conf->base_time){+gcl_data->btl=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR0));+gcl_data->bth=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR1));+}else{+gcl_data->btl=+cpu_to_le32(lower_32_bits(admin_conf->base_time));+gcl_data->bth=+cpu_to_le32(upper_32_bits(admin_conf->base_time));+}++gcl_data->ct=cpu_to_le32(admin_conf->cycle_time);+gcl_data->cte=cpu_to_le32(admin_conf->cycle_time_extension);++for(i=0;i<gcl_len;i++){+structtc_taprio_sched_entry*temp_entry;+structgce*temp_gce=gce+i;++temp_entry=&admin_conf->entries[i];++temp_gce->gate=cpu_to_le32(temp_entry->gate_mask);+temp_gce->period=cpu_to_le32(temp_entry->interval);+}++cbd.length=cpu_to_le16(data_size);+cbd.status_flags=0;++dma=dma_map_single(&priv->si->pdev->dev,gcl_data,+data_size,DMA_TO_DEVICE);+if(dma_mapping_error(&priv->si->pdev->dev,dma)){+netdev_err(priv->si->ndev,"DMA mapping failed!\n");+kfree(gcl_data);+return-ENOMEM;+}++cbd.addr[0]=lower_32_bits(dma);+cbd.addr[1]=upper_32_bits(dma);+cbd.cls=BDCR_CMD_PORT_GCL;++/* Updated by ENETC on completion of the configuration+*command.Azerovalueindicatessuccess.+*/+cbd.status_flags=0;++enetc_send_cmd(priv->si,&cbd);++dma_unmap_single(&priv->si->pdev->dev,dma,data_size,DMA_TO_DEVICE);+kfree(gcl_data);++return0;+}++intenetc_setup_tc_taprio(structnet_device*ndev,void*type_data)+{+structtc_taprio_qopt_offload*taprio=type_data;+structenetc_ndev_priv*priv=netdev_priv(ndev);+inti;++for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?i:0);++returnenetc_setup_taprio(ndev,taprio);+}
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Singed-off-by: Vladimir Oltean [off-list ref]
---
drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++--
drivers/net/ethernet/freescale/enetc/enetc.h | 7 ++++
.../net/ethernet/freescale/enetc/enetc_pf.c | 3 ++
.../net/ethernet/freescale/enetc/enetc_qos.c | 34 +++++++++++++++++++
4 files changed, 55 insertions(+), 2 deletions(-)
@@ -742,6 +742,9 @@ static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,ndev->priv_flags|=IFF_UNICAST_FLT;+if(si->hw_features&ENETC_SI_F_QBV)+priv->active_offloads|=ENETC_F_QBV;+/* pick up primary MAC address from SI */enetc_get_primary_mac_addr(&si->hw,ndev->dev_addr);}
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
7 files changed, 300 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -440,22 +447,6 @@ union enetc_rx_bd {#define EMETC_MAC_ADDR_FILT_RES 3 /* # of reserved entries at the beginning */#define ENETC_MAX_NUM_VFS 2-structenetc_cbd{-union{-struct{-__le32addr[2];-__le32opt[4];-};-__le32data[6];-};-__le16index;-__le16length;-u8cmd;-u8cls;-u8_res;-u8status_flags;-};-#define ENETC_CBD_FLAGS_SF BIT(7) /* short format */#define ENETC_CBD_STATUS_MASK 0xf
@@ -554,3 +545,130 @@ static inline void enetc_set_bdr_prio(struct enetc_hw *hw, int bdr_idx,val|=ENETC_TBMR_SET_PRIO(prio);enetc_txbdr_wr(hw,bdr_idx,ENETC_TBMR,val);}++enumbdcr_cmd_class{+BDCR_CMD_UNSPEC=0,+BDCR_CMD_MAC_FILTER,+BDCR_CMD_VLAN_FILTER,+BDCR_CMD_RSS,+BDCR_CMD_RFS,+BDCR_CMD_PORT_GCL,+BDCR_CMD_RECV_CLASSIFIER,+__BDCR_CMD_MAX_LEN,+BDCR_CMD_MAX_LEN=__BDCR_CMD_MAX_LEN-1,+};++/* class 5, command 0 */+structtgs_gcl_conf{+u8atc;/* init gate value */+u8res[7];+union{+struct{+u8res1[4];+__le16acl_len;+u8res2[2];+};+struct{+u32cctl;+u32ccth;+};+};+};++#define ENETC_CBDR_SGL_IOMEN BIT(0)+#define ENETC_CBDR_SGL_IPVEN BIT(3)+#define ENETC_CBDR_SGL_GTST BIT(4)+#define ENETC_CBDR_SGL_IPV_MASK 0xe++/* gate control list entry */+structgce{+u32period;+u8gate;+u8res[3];+};++/* tgs_gcl_conf address point to this data space */+structtgs_gcl_data{+u32btl;+u32bth;+u32ct;+u32cte;+};++/* class 5, command 1 */+structtgs_gcl_query{+u8res[12];+union{+struct{+__le16acl_len;/* admin list length */+__le16ocl_len;/* operation list length */+};+struct{+u16admin_list_len;+u16oper_list_len;+};+};+};++/* tgs_gcl_query command response data format */+structtgs_gcl_resp{+u32abtl;/* base time */+u32abth;+u32act;/* cycle time */+u32acte;/* cycle time extend */+u32cctl;/* config change time */+u32ccth;+u32obtl;/* operation base time */+u32obth;+u32oct;/* operation cycle time */+u32octe;/* operation cycle time extend */+u32ccel;/* config change error */+u32cceh;+};++structenetc_cbd{+union{+struct{+__le32addr[2];+union{+__le32opt[4];+structtgs_gcl_confgcl_conf;+structtgs_gcl_querygcl_query;+};+};/* Long format */+__le32data[6];+};+__le16index;+__le16length;+u8cmd;+u8cls;+u8_res;+u8status_flags;+};++#define ENETC_PTCFPR(n) (0x1910 + (n) * 4) /* n = [0 ..7] */+#define ENETC_FPE BIT(31)++/* Port capability register 0 */+#define ENETC_PCAPR0_PSFPM BIT(10)+#define ENETC_PCAPR0_PSFP BIT(9)+#define ENETC_PCAPR0_TSN BIT(4)+#define ENETC_PCAPR0_QBU BIT(3)++/* port time gating control register */+#define ENETC_QBV_PTGCR_OFFSET 0x11a00+#define ENETC_QBV_TGE 0x80000000+#define ENETC_QBV_TGPE BIT(30)+#define ENETC_QBV_TGDROP_DISABLE BIT(29)++/* Port time gating capability register */+#define ENETC_QBV_PTGCAPR_OFFSET 0x11a08+#define ENETC_QBV_MAX_GCL_LEN_MASK 0xffff++/* Port time gating admin gate list status register */+#define ENETC_QBV_PTGAGLSR_OFFSET 0x11a10+#define ENETC_QBV_CFG_PEND_MASK 0x00000002++#define ENETC_TGLSTR 0xa200+#define ENETC_TGS_MIN_DIS_MASK 0x80000000+#define ENETC_MIN_LOOKAHEAD_MASK 0xffff
@@ -0,0 +1,130 @@+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)+/* Copyright 2019 NXP */++#include"enetc.h"++#include<net/pkt_sched.h>++staticu16enetc_get_max_gcl_len(structenetc_hw*hw)+{+returnenetc_rd(hw,ENETC_QBV_PTGCAPR_OFFSET)+&ENETC_QBV_MAX_GCL_LEN_MASK;+}++staticintenetc_setup_taprio(structnet_device*ndev,+structtc_taprio_qopt_offload*admin_conf)+{+structenetc_ndev_priv*priv=netdev_priv(ndev);+structenetc_cbdcbd={.cmd=0};+structtgs_gcl_conf*gcl_config;+structtgs_gcl_data*gcl_data;+structgce*gce;+dma_addr_tdma;+u16data_size;+u16gcl_len;+u32temp;+inti;++gcl_len=admin_conf->num_entries;+if(gcl_len>enetc_get_max_gcl_len(&priv->si->hw))+return-EINVAL;++if(admin_conf->enable){+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+usleep_range(10,20);+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp|ENETC_QBV_TGE);+}else{+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+return0;+}++/* Configure the (administrative) gate control list using the+*controlBDdescriptor.+*/+gcl_config=&cbd.gcl_conf;++data_size=sizeof(structtgs_gcl_data)+gcl_len*sizeof(structgce);++gcl_data=kzalloc(data_size,__GFP_DMA|GFP_KERNEL);+if(!gcl_data)+return-ENOMEM;++gce=(structgce*)(gcl_data+1);++/* Since no initial state config in taprio, set gates open as default.+*/+gcl_config->atc=0xff;+gcl_config->acl_len=cpu_to_le16(gcl_len);++if(!admin_conf->base_time){+gcl_data->btl=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR0));+gcl_data->bth=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR1));+}else{+gcl_data->btl=+cpu_to_le32(lower_32_bits(admin_conf->base_time));+gcl_data->bth=+cpu_to_le32(upper_32_bits(admin_conf->base_time));+}++gcl_data->ct=cpu_to_le32(admin_conf->cycle_time);+gcl_data->cte=cpu_to_le32(admin_conf->cycle_time_extension);++for(i=0;i<gcl_len;i++){+structtc_taprio_sched_entry*temp_entry;+structgce*temp_gce=gce+i;++temp_entry=&admin_conf->entries[i];++temp_gce->gate=cpu_to_le32(temp_entry->gate_mask);+temp_gce->period=cpu_to_le32(temp_entry->interval);+}++cbd.length=cpu_to_le16(data_size);+cbd.status_flags=0;++dma=dma_map_single(&priv->si->pdev->dev,gcl_data,+data_size,DMA_TO_DEVICE);+if(dma_mapping_error(&priv->si->pdev->dev,dma)){+netdev_err(priv->si->ndev,"DMA mapping failed!\n");+kfree(gcl_data);+return-ENOMEM;+}++cbd.addr[0]=lower_32_bits(dma);+cbd.addr[1]=upper_32_bits(dma);+cbd.cls=BDCR_CMD_PORT_GCL;++/* Updated by ENETC on completion of the configuration+*command.Azerovalueindicatessuccess.+*/+cbd.status_flags=0;++enetc_send_cmd(priv->si,&cbd);++dma_unmap_single(&priv->si->pdev->dev,dma,data_size,DMA_TO_DEVICE);+kfree(gcl_data);++return0;+}++intenetc_setup_tc_taprio(structnet_device*ndev,void*type_data)+{+structtc_taprio_qopt_offload*taprio=type_data;+structenetc_ndev_priv*priv=netdev_priv(ndev);+inti;++for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?i:0);++returnenetc_setup_taprio(ndev,taprio);+}
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
changes:
- fix for enetc_sched_speed_set() define for different config.
drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++--
drivers/net/ethernet/freescale/enetc/enetc.h | 8 +++++
.../net/ethernet/freescale/enetc/enetc_pf.c | 3 ++
.../net/ethernet/freescale/enetc/enetc_qos.c | 34 +++++++++++++++++++
4 files changed, 56 insertions(+), 2 deletions(-)
@@ -742,6 +742,9 @@ static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,ndev->priv_flags|=IFF_UNICAST_FLT;+if(si->hw_features&ENETC_SI_F_QBV)+priv->active_offloads|=ENETC_F_QBV;+/* pick up primary MAC address from SI */enetc_get_primary_mac_addr(&si->hw,ndev->dev_addr);}
From: David Miller <davem@davemloft.net> Date: 2019-11-12 18:57:41
From: Po Liu <redacted>
Date: Tue, 12 Nov 2019 08:42:55 +0000
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
v2:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
v3:
- fix the compiling vf module failure issue:
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
- remove defines not used in this patch
- fix hardware endian issue
- make the qbv set code more rubust with some error condition may occur.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 2 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 84 ++++++++---
.../net/ethernet/freescale/enetc/enetc_qos.c | 134 ++++++++++++++++++
7 files changed, 239 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -440,22 +441,6 @@ union enetc_rx_bd {#define EMETC_MAC_ADDR_FILT_RES 3 /* # of reserved entries at the beginning */#define ENETC_MAX_NUM_VFS 2-structenetc_cbd{-union{-struct{-__le32addr[2];-__le32opt[4];-};-__le32data[6];-};-__le16index;-__le16length;-u8cmd;-u8cls;-u8_res;-u8status_flags;-};-#define ENETC_CBD_FLAGS_SF BIT(7) /* short format */#define ENETC_CBD_STATUS_MASK 0xf
@@ -554,3 +539,70 @@ static inline void enetc_set_bdr_prio(struct enetc_hw *hw, int bdr_idx,val|=ENETC_TBMR_SET_PRIO(prio);enetc_txbdr_wr(hw,bdr_idx,ENETC_TBMR,val);}++enumbdcr_cmd_class{+BDCR_CMD_UNSPEC=0,+BDCR_CMD_MAC_FILTER,+BDCR_CMD_VLAN_FILTER,+BDCR_CMD_RSS,+BDCR_CMD_RFS,+BDCR_CMD_PORT_GCL,+BDCR_CMD_RECV_CLASSIFIER,+__BDCR_CMD_MAX_LEN,+BDCR_CMD_MAX_LEN=__BDCR_CMD_MAX_LEN-1,+};++/* class 5, command 0 */+structtgs_gcl_conf{+u8atc;/* init gate value */+u8res[7];+struct{+u8res1[4];+__le16acl_len;+u8res2[2];+};+};++/* gate control list entry */+structgce{+__le32period;+u8gate;+u8res[3];+};++/* tgs_gcl_conf address point to this data space */+structtgs_gcl_data{+__le32btl;+__le32bth;+__le32ct;+__le32cte;+structgceentry[0];+};++structenetc_cbd{+union{+struct{+__le32addr[2];+union{+__le32opt[4];+structtgs_gcl_confgcl_conf;+};+};/* Long format */+__le32data[6];+};+__le16index;+__le16length;+u8cmd;+u8cls;+u8_res;+u8status_flags;+};++/* port time gating control register */+#define ENETC_QBV_PTGCR_OFFSET 0x11a00+#define ENETC_QBV_TGE BIT(31)+#define ENETC_QBV_TGPE BIT(30)++/* Port time gating capability register */+#define ENETC_QBV_PTGCAPR_OFFSET 0x11a08+#define ENETC_QBV_MAX_GCL_LEN_MASK GENMASK(15, 0)
@@ -0,0 +1,134 @@+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)+/* Copyright 2019 NXP */++#include"enetc.h"++#include<net/pkt_sched.h>++staticu16enetc_get_max_gcl_len(structenetc_hw*hw)+{+returnenetc_rd(hw,ENETC_QBV_PTGCAPR_OFFSET)+&ENETC_QBV_MAX_GCL_LEN_MASK;+}++staticintenetc_setup_taprio(structnet_device*ndev,+structtc_taprio_qopt_offload*admin_conf)+{+structenetc_ndev_priv*priv=netdev_priv(ndev);+structenetc_cbdcbd={.cmd=0};+structtgs_gcl_conf*gcl_config;+structtgs_gcl_data*gcl_data;+structgce*gce;+dma_addr_tdma;+u16data_size;+u16gcl_len;+u32tge;+interr;+inti;++if(admin_conf->num_entries>enetc_get_max_gcl_len(&priv->si->hw))+return-EINVAL;+gcl_len=admin_conf->num_entries;++tge=enetc_rd(&priv->si->hw,ENETC_QBV_PTGCR_OFFSET);+if(!admin_conf->enable){+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+tge&(~ENETC_QBV_TGE));+return0;+}++if(admin_conf->cycle_time>(u32)~0||+admin_conf->cycle_time_extension>(u32)~0)+return-EINVAL;++/* Configure the (administrative) gate control list using the+*controlBDdescriptor.+*/+gcl_config=&cbd.gcl_conf;++data_size=struct_size(gcl_data,entry,gcl_len);+gcl_data=kzalloc(data_size,__GFP_DMA|GFP_KERNEL);+if(!gcl_data)+return-ENOMEM;++gce=(structgce*)(gcl_data+1);++/* Set all gates open as default */+gcl_config->atc=0xff;+gcl_config->acl_len=cpu_to_le16(gcl_len);++if(!admin_conf->base_time){+gcl_data->btl=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR0));+gcl_data->bth=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR1));+}else{+gcl_data->btl=+cpu_to_le32(lower_32_bits(admin_conf->base_time));+gcl_data->bth=+cpu_to_le32(upper_32_bits(admin_conf->base_time));+}++gcl_data->ct=cpu_to_le32(admin_conf->cycle_time);+gcl_data->cte=cpu_to_le32(admin_conf->cycle_time_extension);++for(i=0;i<gcl_len;i++){+structtc_taprio_sched_entry*temp_entry;+structgce*temp_gce=gce+i;++temp_entry=&admin_conf->entries[i];++temp_gce->gate=(u8)temp_entry->gate_mask;+temp_gce->period=cpu_to_le32(temp_entry->interval);+}++cbd.length=cpu_to_le16(data_size);+cbd.status_flags=0;++dma=dma_map_single(&priv->si->pdev->dev,gcl_data,+data_size,DMA_TO_DEVICE);+if(dma_mapping_error(&priv->si->pdev->dev,dma)){+netdev_err(priv->si->ndev,"DMA mapping failed!\n");+kfree(gcl_data);+return-ENOMEM;+}++cbd.addr[0]=lower_32_bits(dma);+cbd.addr[1]=upper_32_bits(dma);+cbd.cls=BDCR_CMD_PORT_GCL;+cbd.status_flags=0;++enetc_wr(&priv->si->hw,ENETC_QBV_PTGCR_OFFSET,+tge&(~ENETC_QBV_TGE));++usleep_range(10,20);++enetc_wr(&priv->si->hw,ENETC_QBV_PTGCR_OFFSET,+tge|ENETC_QBV_TGE);++err=enetc_send_cmd(priv->si,&cbd);+if(err)+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+tge&(~ENETC_QBV_TGE));++dma_unmap_single(&priv->si->pdev->dev,dma,data_size,DMA_TO_DEVICE);+kfree(gcl_data);++returnerr;+}++intenetc_setup_tc_taprio(structnet_device*ndev,void*type_data)+{+structtc_taprio_qopt_offload*taprio=type_data;+structenetc_ndev_priv*priv=netdev_priv(ndev);+inti;++for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?i:0);++returnenetc_setup_taprio(ndev,taprio);+}
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++--
drivers/net/ethernet/freescale/enetc/enetc.h | 8 +++++
.../net/ethernet/freescale/enetc/enetc_hw.h | 5 +++
.../net/ethernet/freescale/enetc/enetc_pf.c | 3 ++
.../net/ethernet/freescale/enetc/enetc_qos.c | 34 +++++++++++++++++++
5 files changed, 61 insertions(+), 2 deletions(-)
@@ -742,6 +742,9 @@ static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,ndev->priv_flags|=IFF_UNICAST_FLT;+if(si->hw_features&ENETC_SI_F_QBV)+priv->active_offloads|=ENETC_F_QBV;+/* pick up primary MAC address from SI */enetc_get_primary_mac_addr(&si->hw,ndev->dev_addr);}
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
v2:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
v3:
- fix the compiling vf module failure issue:
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
- remove defines not used in this patch
- fix hardware endian issue
- make the qbv set code more rubust with some error condition may occur.
v4:
- delete hardware qbv disable before enable it
- fix when enetc_setup_taprio() return error condition, restore priority
set.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 2 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 84 +++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 138 ++++++++++++++++++
7 files changed, 243 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -440,22 +441,6 @@ union enetc_rx_bd {#define EMETC_MAC_ADDR_FILT_RES 3 /* # of reserved entries at the beginning */#define ENETC_MAX_NUM_VFS 2-structenetc_cbd{-union{-struct{-__le32addr[2];-__le32opt[4];-};-__le32data[6];-};-__le16index;-__le16length;-u8cmd;-u8cls;-u8_res;-u8status_flags;-};-#define ENETC_CBD_FLAGS_SF BIT(7) /* short format */#define ENETC_CBD_STATUS_MASK 0xf
@@ -554,3 +539,70 @@ static inline void enetc_set_bdr_prio(struct enetc_hw *hw, int bdr_idx,val|=ENETC_TBMR_SET_PRIO(prio);enetc_txbdr_wr(hw,bdr_idx,ENETC_TBMR,val);}++enumbdcr_cmd_class{+BDCR_CMD_UNSPEC=0,+BDCR_CMD_MAC_FILTER,+BDCR_CMD_VLAN_FILTER,+BDCR_CMD_RSS,+BDCR_CMD_RFS,+BDCR_CMD_PORT_GCL,+BDCR_CMD_RECV_CLASSIFIER,+__BDCR_CMD_MAX_LEN,+BDCR_CMD_MAX_LEN=__BDCR_CMD_MAX_LEN-1,+};++/* class 5, command 0 */+structtgs_gcl_conf{+u8atc;/* init gate value */+u8res[7];+struct{+u8res1[4];+__le16acl_len;+u8res2[2];+};+};++/* gate control list entry */+structgce{+__le32period;+u8gate;+u8res[3];+};++/* tgs_gcl_conf address point to this data space */+structtgs_gcl_data{+__le32btl;+__le32bth;+__le32ct;+__le32cte;+structgceentry[0];+};++structenetc_cbd{+union{+struct{+__le32addr[2];+union{+__le32opt[4];+structtgs_gcl_confgcl_conf;+};+};/* Long format */+__le32data[6];+};+__le16index;+__le16length;+u8cmd;+u8cls;+u8_res;+u8status_flags;+};++/* port time gating control register */+#define ENETC_QBV_PTGCR_OFFSET 0x11a00+#define ENETC_QBV_TGE BIT(31)+#define ENETC_QBV_TGPE BIT(30)++/* Port time gating capability register */+#define ENETC_QBV_PTGCAPR_OFFSET 0x11a08+#define ENETC_QBV_MAX_GCL_LEN_MASK GENMASK(15, 0)
@@ -0,0 +1,138 @@+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)+/* Copyright 2019 NXP */++#include"enetc.h"++#include<net/pkt_sched.h>++staticu16enetc_get_max_gcl_len(structenetc_hw*hw)+{+returnenetc_rd(hw,ENETC_QBV_PTGCAPR_OFFSET)+&ENETC_QBV_MAX_GCL_LEN_MASK;+}++staticintenetc_setup_taprio(structnet_device*ndev,+structtc_taprio_qopt_offload*admin_conf)+{+structenetc_ndev_priv*priv=netdev_priv(ndev);+structenetc_cbdcbd={.cmd=0};+structtgs_gcl_conf*gcl_config;+structtgs_gcl_data*gcl_data;+structgce*gce;+dma_addr_tdma;+u16data_size;+u16gcl_len;+u32tge;+interr;+inti;++if(admin_conf->num_entries>enetc_get_max_gcl_len(&priv->si->hw))+return-EINVAL;+gcl_len=admin_conf->num_entries;++tge=enetc_rd(&priv->si->hw,ENETC_QBV_PTGCR_OFFSET);+if(!admin_conf->enable){+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+tge&(~ENETC_QBV_TGE));+return0;+}++if(admin_conf->cycle_time>U32_MAX||+admin_conf->cycle_time_extension>U32_MAX)+return-EINVAL;++/* Configure the (administrative) gate control list using the+*controlBDdescriptor.+*/+gcl_config=&cbd.gcl_conf;++data_size=struct_size(gcl_data,entry,gcl_len);+gcl_data=kzalloc(data_size,__GFP_DMA|GFP_KERNEL);+if(!gcl_data)+return-ENOMEM;++gce=(structgce*)(gcl_data+1);++/* Set all gates open as default */+gcl_config->atc=0xff;+gcl_config->acl_len=cpu_to_le16(gcl_len);++if(!admin_conf->base_time){+gcl_data->btl=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR0));+gcl_data->bth=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR1));+}else{+gcl_data->btl=+cpu_to_le32(lower_32_bits(admin_conf->base_time));+gcl_data->bth=+cpu_to_le32(upper_32_bits(admin_conf->base_time));+}++gcl_data->ct=cpu_to_le32(admin_conf->cycle_time);+gcl_data->cte=cpu_to_le32(admin_conf->cycle_time_extension);++for(i=0;i<gcl_len;i++){+structtc_taprio_sched_entry*temp_entry;+structgce*temp_gce=gce+i;++temp_entry=&admin_conf->entries[i];++temp_gce->gate=(u8)temp_entry->gate_mask;+temp_gce->period=cpu_to_le32(temp_entry->interval);+}++cbd.length=cpu_to_le16(data_size);+cbd.status_flags=0;++dma=dma_map_single(&priv->si->pdev->dev,gcl_data,+data_size,DMA_TO_DEVICE);+if(dma_mapping_error(&priv->si->pdev->dev,dma)){+netdev_err(priv->si->ndev,"DMA mapping failed!\n");+kfree(gcl_data);+return-ENOMEM;+}++cbd.addr[0]=lower_32_bits(dma);+cbd.addr[1]=upper_32_bits(dma);+cbd.cls=BDCR_CMD_PORT_GCL;+cbd.status_flags=0;++enetc_wr(&priv->si->hw,ENETC_QBV_PTGCR_OFFSET,+tge|ENETC_QBV_TGE);++err=enetc_send_cmd(priv->si,&cbd);+if(err)+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+tge&(~ENETC_QBV_TGE));++dma_unmap_single(&priv->si->pdev->dev,dma,data_size,DMA_TO_DEVICE);+kfree(gcl_data);++returnerr;+}++intenetc_setup_tc_taprio(structnet_device*ndev,void*type_data)+{+structtc_taprio_qopt_offload*taprio=type_data;+structenetc_ndev_priv*priv=netdev_priv(ndev);+interr;+inti;++for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?i:0);++err=enetc_setup_taprio(ndev,taprio);++if(err)+for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?0:i);++returnerr;+}
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++--
drivers/net/ethernet/freescale/enetc/enetc.h | 8 +++++
.../net/ethernet/freescale/enetc/enetc_hw.h | 5 +++
.../net/ethernet/freescale/enetc/enetc_pf.c | 3 ++
.../net/ethernet/freescale/enetc/enetc_qos.c | 34 +++++++++++++++++++
5 files changed, 61 insertions(+), 2 deletions(-)
@@ -742,6 +742,9 @@ static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,ndev->priv_flags|=IFF_UNICAST_FLT;+if(si->hw_features&ENETC_SI_F_QBV)+priv->active_offloads|=ENETC_F_QBV;+/* pick up primary MAC address from SI */enetc_get_primary_mac_addr(&si->hw,ndev->dev_addr);}
From: David Miller <davem@davemloft.net> Date: 2019-11-16 20:49:41
From: Po Liu <redacted>
Date: Fri, 15 Nov 2019 03:33:41 +0000
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
From: Ivan Khoronzhuk <hidden> Date: 2019-11-15 15:20:30
On Fri, Nov 15, 2019 at 03:33:33AM +0000, Po Liu wrote:
quoted hunk
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
v2:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
v3:
- fix the compiling vf module failure issue:
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
- remove defines not used in this patch
- fix hardware endian issue
- make the qbv set code more rubust with some error condition may occur.
v4:
- delete hardware qbv disable before enable it
- fix when enetc_setup_taprio() return error condition, restore priority
set.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 2 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 84 +++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 138 ++++++++++++++++++
7 files changed, 243 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
allocation has not been supported and it is too expensive to use
extended RX BDs if timestamping is not used, this option enables
extended RX BDs in order to support hardware timestamping.
+
+config FSL_ENETC_QOS
+ bool "ENETC hardware Time-sensitive Network support"
+ depends on (FSL_ENETC || FSL_ENETC_VF) && NET_SCH_TAPRIO
+ help
+ There are Time-Sensitive Network(TSN) capabilities(802.1Qbv/802.1Qci
+ /802.1Qbu etc.) supported by ENETC. These TSN capabilities can be set
+ enable/disable from user space via Qos commands(tc). In the kernel
+ side, it can be loaded by Qos driver. Currently, it is only support
+ taprio(802.1Qbv).
Answer on comment in v3,
Problem not in errata - problem in w/a.
If it gets to unknown state - better restart it, but not silently.
I see dropped the reset in this version, you probably better know the errata
w/a.
but I've expected it to be reseted by asking user explicitly to do this if oper
cycle is present as it's probably not what is expected, if no oper state then
reset and start as it was.
Now the reset is removed from configuration, even if there is no oper state.
Probably it's not good. But you better know.
What actually the problem to save variable like priv->qbv_enabled and use it for
making appropriate decision?
JFI, you can use also link on allocated configuration from taprio with API from
taprio:
taprio_offload_free(taprio);
taprio_offload_get(taprio);
preventing taprio struct from to be freed.
And use taprio pointer as a boolen instead of priv->qbv_enabled.
Kind of:
if (priv->taprio)
taprio_offload_free(priv->taprio);
priv->taprio = taprio->enable ? taprio_offload_get(taprio) :
NULL;
So you have saved conf settings (seems like you don't need, but that's for now)
and at the same time a key to read enable/disable state.
From: David Miller <davem@davemloft.net> Date: 2019-11-16 20:49:35
From: Po Liu <redacted>
Date: Fri, 15 Nov 2019 03:33:33 +0000
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
From: Ivan Khoronzhuk <hidden> Date: 2019-11-14 18:51:37
On Thu, Nov 14, 2019 at 05:12:30AM +0000, Po Liu wrote:
quoted hunk
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
v2:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
v3:
- fix the compiling vf module failure issue:
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
- remove defines not used in this patch
- fix hardware endian issue
- make the qbv set code more rubust with some error condition may occur.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 2 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 84 ++++++++---
.../net/ethernet/freescale/enetc/enetc_qos.c | 134 ++++++++++++++++++
7 files changed, 239 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
allocation has not been supported and it is too expensive to use
extended RX BDs if timestamping is not used, this option enables
extended RX BDs in order to support hardware timestamping.
+
+config FSL_ENETC_QOS
+ bool "ENETC hardware Time-sensitive Network support"
+ depends on (FSL_ENETC || FSL_ENETC_VF) && NET_SCH_TAPRIO
+ help
+ There are Time-Sensitive Network(TSN) capabilities(802.1Qbv/802.1Qci
+ /802.1Qbu etc.) supported by ENETC. These TSN capabilities can be set
+ enable/disable from user space via Qos commands(tc). In the kernel
+ side, it can be loaded by Qos driver. Currently, it is only support
+ taprio(802.1Qbv).
Sorry, but, please, before sending new version, be sure you understand what
should be changed.
Let's back to IEEE Std 802.1Q
Do you know what means cycle time extension that is programmed here.
And why needed admin and oper configurations, and their base times?
It's needed to not stop active oper configuration (that actually this
function do), so that it's active till new one, that is admin, will
be able to replace it.
If user wants to stop it, and then load new one, he has to do it
himself. But, when some configuration is active - that is OPER at the
moment - and user requests w/o stopping it new configuration in some
new admin base time, the oper stay active till this admin base time,
then dropped in hw.
What this code do, it's in hidden way, stop oper configuration at
the time of configuration and no matter which admit base time is.
That's definitely wrong. Just look how sw version works.
And why all this admin/oper headache exists in IEEE Std 802.1Q
exactly for this reason.
So, if oper configuration exists at the moment of calling taprio
configuration and no way to apply new on in some future time
(admin base time), the code should say to user:
Please, stop prev. oper configuration - then prog new one.
The taprio interface is common and can't be treated differently
depending on hw.
Hope it's clean.
-----Original Message-----
From: Ivan Khoronzhuk <redacted>
Sent: 2019年11月15日 2:51
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; vinicius.gomes@intel.com;
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [v3,net-next, 1/2] enetc: Configure the Time-Aware Scheduler
via tc-taprio offload
Caution: EXT Email
On Thu, Nov 14, 2019 at 05:12:30AM +0000, Po Liu wrote:
quoted
ENETC supports in hardware for time-based egress shaping according to
IEEE 802.1Qbv. This patch implement the Qbv enablement by the hardware
offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
v2:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
v3:
- fix the compiling vf module failure issue:
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-
Sorry, but, please, before sending new version, be sure you understand what
should be changed.
Let's back to IEEE Std 802.1Q
Do you know what means cycle time extension that is programmed here.
And why needed admin and oper configurations, and their base times?
It's needed to not stop active oper configuration (that actually this function do),
so that it's active till new one, that is admin, will be able to replace it.
If user wants to stop it, and then load new one, he has to do it himself. But,
when some configuration is active - that is OPER at the moment - and user
requests w/o stopping it new configuration in some new admin base time, the
oper stay active till this admin base time, then dropped in hw.
What this code do, it's in hidden way, stop oper configuration at the time of
configuration and no matter which admit base time is.
I am definitely know the spec in the Qbv. Here is hardware errata which I have mentioned in previous feedback in v2.
That's definitely wrong. Just look how sw version works.
And why all this admin/oper headache exists in IEEE Std 802.1Q exactly for this
reason.
So, if oper configuration exists at the moment of calling taprio configuration
and no way to apply new on in some future time (admin base time), the code
should say to user:
Please, stop prev. oper configuration - then prog new one.
The taprio interface is common and can't be treated differently depending on
hw.
Hope it's clean.
From: David Miller <davem@davemloft.net> Date: 2019-11-12 18:57:35
From: Po Liu <redacted>
Date: Tue, 12 Nov 2019 08:42:49 +0000
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
From: Ivan Khoronzhuk <hidden> Date: 2019-11-12 21:10:08
Hello,
On Tue, Nov 12, 2019 at 08:42:49AM +0000, Po Liu wrote:
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
7 files changed, 300 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
Sorry didn't see v2, so i duplicate my question here:
This patch is for taprio offload, I see that mqprio is related and is part of
taprio offload configuration. But taprio offload has own mqprio settings.
The taprio mqprio part is not offloaded with TC_SETUP_QDISC_MQPRIO.
So, a combination of mqprio and tario qdiscs used.
Could you please share the commands were used for your setup?
And couple interesting questions about all of this:
- The taprio qdisc has to have mqprio settings, but if it's done with
mqprio then it just skipped (by reading tc class num).
- If no separate mqprio qdisc configuration then mqprio conf from taprio
is set, who should restore tc mappings when taprio qdisc is unloaded?
Maybe there is reason to implement TC_SETUP_QDISC_MQPRIO offload in taprio
since it's required feature?
Would be better to move changes for mqprio in separate patch with explanation.
Better do the upper qbv enable/disable procedure closer to enetc_send_cmd() or
at least after kzalloc that can fail, no need to restore then.
+
+ /* Configure the (administrative) gate control list using the
+ * control BD descriptor.
+ */
+ gcl_config = &cbd.gcl_conf;
+
+ data_size = sizeof(struct tgs_gcl_data) + gcl_len * sizeof(struct gce);
+
+ gcl_data = kzalloc(data_size, __GFP_DMA | GFP_KERNEL);
+ if (!gcl_data)
+ return -ENOMEM;
+
+ gce = (struct gce *)(gcl_data + 1);
+
+ /* Since no initial state config in taprio, set gates open as default.
+ */
tc-taprio and IEEE Qbv allows to change configuration in flight, so that oper
state is active till new admin start time. So, here comment says it does
initial state config, if in-flight feature is not supported then error has to
be returned instead of silently rewriting configuration. But if it can be
implemented then state should be remembered/verified in order to not brake oper
configuration?
Ok, this is maximum number of schedules.
According to tc-taprio it's possible to set cycle period more then schedules
actually can consume. If cycle time is more, then last gate's state can be
kept till the end of cycle. But if last schedule has it's own interval set
then gates should be closed till the end of cycle or no? if it has to be closed,
then one more endl schedule should be present closing gates at the end of list
for the rest cycle time. Can be implemented in h/w but just to be sure, how it's
done in h/w?
Not sure it's good idea to write values w/o verification, The cycle time and
time extension is 64 values, so it's supposed them to be more then 4,3
seconds, it's probably not a case, but better return error if it's more.
then why enable/disable at the beginning for whole qbv scheduler, maybe
better do it together? Or better say, what if setup_taprio failed, who restore
configuration?
-----Original Message-----
From: Ivan Khoronzhuk <redacted>
Sent: 2019年11月13日 5:10
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; vinicius.gomes@intel.com;
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [v2,net-next, 1/2] enetc: Configure the Time-Aware Scheduler
via tc-taprio offload
Caution: EXT Email
Hello,
On Tue, Nov 12, 2019 at 08:42:49AM +0000, Po Liu wrote:
quoted
ENETC supports in hardware for time-based egress shaping according to
IEEE 802.1Qbv. This patch implement the Qbv enablement by the hardware
offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
7 files changed, 300 insertions(+), 22 deletions(-) create mode 100644
drivers/net/ethernet/freescale/enetc/enetc_qos.c
[...]
quoted
@@ -1483,6 +1479,19 @@ int enetc_setup_tc(struct net_device *ndev, enum
Sorry didn't see v2, so i duplicate my question here:
This patch is for taprio offload, I see that mqprio is related and is part of taprio
offload configuration. But taprio offload has own mqprio settings.
The taprio mqprio part is not offloaded with TC_SETUP_QDISC_MQPRIO.
So, a combination of mqprio and tario qdiscs used.
Could you please share the commands were used for your setup?
And couple interesting questions about all of this:
- The taprio qdisc has to have mqprio settings, but if it's done with mqprio then
it just skipped (by reading tc class num).
- If no separate mqprio qdisc configuration then mqprio conf from taprio is set,
who should restore tc mappings when taprio qdisc is unloaded?
Maybe there is reason to implement TC_SETUP_QDISC_MQPRIO offload in
taprio since it's required feature?
Mqprio offload with TC_SETUP_QDISC_MQPRIO would be good or even the plus with num_tc would fix some hack. This has a discussion with Vinicius Gomes for a future patch fix.
I know the problem is the mqprio will be set after the offload function. But offload function may use some for hardware set.
Would be better to move changes for mqprio in separate patch with
explanation.
Better do the upper qbv enable/disable procedure closer to enetc_send_cmd()
or at least after kzalloc that can fail, no need to restore then.
After saving the 'if' suggest by Simon Horman, the enable part could move close to the cmd().
quoted
+
+ /* Configure the (administrative) gate control list using the
+ * control BD descriptor.
+ */
+ gcl_config = &cbd.gcl_conf;
+
+ data_size = sizeof(struct tgs_gcl_data) + gcl_len *
+ sizeof(struct gce);
+
+ gcl_data = kzalloc(data_size, __GFP_DMA | GFP_KERNEL);
+ if (!gcl_data)
+ return -ENOMEM;
+
+ gce = (struct gce *)(gcl_data + 1);
+
+ /* Since no initial state config in taprio, set gates open as default.
+ */
tc-taprio and IEEE Qbv allows to change configuration in flight, so that oper
state is active till new admin start time. So, here comment says it does initial
state config, if in-flight feature is not supported then error has to be returned
instead of silently rewriting configuration. But if it can be implemented then
state should be remembered/verified in order to not brake oper configuration?
I think this is ok as per standard. Also see this comment in
net/sched/sch_taprio.c:
/* Until the schedule starts, all the queues are open */
I would change the comment.
Ok, this is maximum number of schedules.
According to tc-taprio it's possible to set cycle period more then schedules
actually can consume. If cycle time is more, then last gate's state can be kept
till the end of cycle. But if last schedule has it's own interval set then gates
should be closed till the end of cycle or no? if it has to be closed, then one more
endl schedule should be present closing gates at the end of list for the rest cycle
time. Can be implemented in h/w but just to be sure, how it's done in h/w?
There is already check the list len in up code.
if (admin_conf->num_entries > enetc_get_max_gcl_len(&priv->si->hw))
return -EINVAL;
gcl_len = admin_conf->num_entries;
Not sure it's good idea to write values w/o verification, The cycle time and time
extension is 64 values, so it's supposed them to be more then 4,3 seconds, it's
probably not a case, but better return error if it's more.
Can add a check for cycle time and extension since type not match.
So, the interval can be up to 4.3 seconds for one schedule?
That is, one cycle can be one schedule.
great.
quoted
+ }
There is no schedule cmd set, so only SetGateStates is supported?
But anyway it's Ok.
quoted
+
+ cbd.length = cpu_to_le16(data_size);
+ cbd.status_flags = 0;
+
+ dma = dma_map_single(&priv->si->pdev->dev, gcl_data,
+ data_size, DMA_TO_DEVICE);
+ if (dma_mapping_error(&priv->si->pdev->dev, dma)) {
+ netdev_err(priv->si->ndev, "DMA mapping failed!\n");
+ kfree(gcl_data);
+ return -ENOMEM;
+ }
+
+ cbd.addr[0] = lower_32_bits(dma);
+ cbd.addr[1] = upper_32_bits(dma);
+ cbd.cls = BDCR_CMD_PORT_GCL;
+
+ /* Updated by ENETC on completion of the configuration
+ * command. A zero value indicates success.
+ */
+ cbd.status_flags = 0;
It's updated on completion by setting 0 on success, then why it's here set to 0
but not 1 and not verified afterwards?
This byte is feedback by hardware after enetc_send_cmd. Hardware require the cbd space set status_flags 0 before send to hardware.
No choice of larger than 0 before send to hardware.
But you mind me the enetc_send_cmd() need to check return value.
+ kfree(gcl_data);
+
+ return 0;
+}
+
+int enetc_setup_tc_taprio(struct net_device *ndev, void *type_data) {
+ struct tc_taprio_qopt_offload *taprio = type_data;
+ struct enetc_ndev_priv *priv = netdev_priv(ndev);
+ int i;
+
+ for (i = 0; i < priv->num_tx_rings; i++)
+ enetc_set_bdr_prio(&priv->si->hw,
+ priv->tx_ring[i]->index,
+ taprio->enable ? i : 0);
then why enable/disable at the beginning for whole qbv scheduler, maybe
better do it together? Or better say, what if setup_taprio failed, who restore
configuration?
You remind me the enetc_send_cmd() need to check return value.
From: Ivan Khoronzhuk <hidden> Date: 2019-11-13 13:41:53
On Wed, Nov 13, 2019 at 03:45:08AM +0000, Po Liu wrote:
Hi Ivan,
quoted
-----Original Message-----
From: Ivan Khoronzhuk <redacted>
Sent: 2019年11月13日 5:10
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; vinicius.gomes@intel.com;
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [v2,net-next, 1/2] enetc: Configure the Time-Aware Scheduler
via tc-taprio offload
Caution: EXT Email
Hello,
On Tue, Nov 12, 2019 at 08:42:49AM +0000, Po Liu wrote:
quoted
ENETC supports in hardware for time-based egress shaping according to
IEEE 802.1Qbv. This patch implement the Qbv enablement by the hardware
offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable this
tsn feature, or else, return not support.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
7 files changed, 300 insertions(+), 22 deletions(-) create mode 100644
drivers/net/ethernet/freescale/enetc/enetc_qos.c
[...]
quoted
@@ -1483,6 +1479,19 @@ int enetc_setup_tc(struct net_device *ndev, enum
Sorry didn't see v2, so i duplicate my question here:
This patch is for taprio offload, I see that mqprio is related and is part of taprio
offload configuration. But taprio offload has own mqprio settings.
The taprio mqprio part is not offloaded with TC_SETUP_QDISC_MQPRIO.
So, a combination of mqprio and tario qdiscs used.
Could you please share the commands were used for your setup?
So, the TC_SETUP_QDISC_MQPRIO is really not required here, and mqprio qdisc is
not used. Then why is it here, should be placed in separate patch at least.
But even the comb mqprio qdisc and taprio qdisc are used together then taprio
requires hw offload also. I'm Ok to add it later to taprio, and I'm asking
about it because I need it also, what ever way it could be added.
Not clear how you combined mqprio qdisc and taprio now to get it working
From this command:
tc qdisc replace dev eth0 parent root handle 100 taprio num_tc 8 map 0 1 2 3 4
5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 01 sched-entry S 02
300000 flags 0x2
I can conclude that some default h/w mapping (one to one) were used and no need
to use mqprio qdisc, the command above is enough.
Is it true?
Then move it to spearate patch please as it's not taprio related yet.
quoted
And couple interesting questions about all of this:
- The taprio qdisc has to have mqprio settings, but if it's done with mqprio then
it just skipped (by reading tc class num).
- If no separate mqprio qdisc configuration then mqprio conf from taprio is set,
who should restore tc mappings when taprio qdisc is unloaded?
Maybe there is reason to implement TC_SETUP_QDISC_MQPRIO offload in
taprio since it's required feature?
[...]
quoted
quoted
+
+ /* Configure the (administrative) gate control list using the
+ * control BD descriptor.
+ */
+ gcl_config = &cbd.gcl_conf;
+
+ data_size = sizeof(struct tgs_gcl_data) + gcl_len *
+ sizeof(struct gce);
+
+ gcl_data = kzalloc(data_size, __GFP_DMA | GFP_KERNEL);
+ if (!gcl_data)
+ return -ENOMEM;
+
+ gce = (struct gce *)(gcl_data + 1);
+
+ /* Since no initial state config in taprio, set gates open as default.
+ */
tc-taprio and IEEE Qbv allows to change configuration in flight, so that oper
state is active till new admin start time. So, here comment says it does initial
state config, if in-flight feature is not supported then error has to be returned
instead of silently rewriting configuration. But if it can be implemented then
state should be remembered/verified in order to not brake oper configuration?
I think this is ok as per standard. Also see this comment in
net/sched/sch_taprio.c:
From the code above (duplicate for convenience):
if (admin_conf->enable) {
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp & (~ENETC_QBV_TGE));
usleep_range(10, 20);
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp | ENETC_QBV_TGE);
} else {
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp & (~ENETC_QBV_TGE));
return 0;
}
I see that's not true, as Simon noted, you have same command:
enetc_wr(&priv->si->hw, ENETC_QBV_PTGCR_OFFSET, temp & (~ENETC_QBV_TGE));
before enabling and for disabling. I guess it's stop command, that is disable
qbv. So, before enabling new configuration with enetc_setup_tc(), the tario is
inited|cleared|reseted|rebooted|defaulted|offed but not updated. It means no
in-flight capabilities or they are ignored.
JFI, it's possible to do first time:
tc qdisc replace dev eth0 parent root handle 100 taprio num_tc 8 map 0 1 2 3 4
5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 01 sched-entry S 02
300000 flags 0x2
and then:
tc qdisc replace dev eth0 parent root handle 100 taprio base-time 01
sched-entry S 02 200000 flags 0x2
Do it many times, but w/o mqprio configuration.
So, this function must return error if it cannot be done, as above commands
suppose that configuration can be updated in runtime, that is, set ADMIN cycle
while OPER cycle is still active for some time and not broken like it's done
now. If it can be achieved then no need to do
enetc_wr(&priv->si->hw, ENETC_QBV_PTGCR_OFFSET, temp & (~ENETC_QBV_TGE));
when admin_conf->enable.
So or return error, or do it appropriately.
/* Until the schedule starts, all the queues are open */
I would change the comment.
Ok, this is maximum number of schedules.
According to tc-taprio it's possible to set cycle period more then schedules
actually can consume. If cycle time is more, then last gate's state can be kept
till the end of cycle. But if last schedule has it's own interval set then gates
should be closed till the end of cycle or no? if it has to be closed, then one more
endl schedule should be present closing gates at the end of list for the rest cycle
time. Can be implemented in h/w but just to be sure, how it's done in h/w?
There is already check the list len in up code.
if (admin_conf->num_entries > enetc_get_max_gcl_len(&priv->si->hw))
return -EINVAL;
gcl_len = admin_conf->num_entries;
I mean +1 schedule to finalize the cycle with closed gates if last schedule
has provided time interval. If I set couple schedules, with intervals, and cycle
time more then those schedules consume, then I suppose the gates closed for the
rest time of cycle, probably.
Example:
sched1 ----> shced2 ----> time w/o scheds -> cycle end
gate 1 gate 2 no gates
But if shced2 is last one then gate 2 is opened till the end of cycle.
So, to close gate one more shched is needed with closed gates to finalize it.
Or it's supposed that gate2 is opened till the end of cycle,
How is it in you case. Or this is can be provided by configuration from tc?
It's question not statement. Just though. Anyway i'll verify later it can be
done with tc and how it's done in sw version, just interesting how your h/w
works.
-----Original Message-----
From: Ivan Khoronzhuk <redacted>
Sent: 2019年11月13日 21:42
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; vinicius.gomes@intel.com;
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: Re: [EXT] Re: [v2,net-next, 1/2] enetc: Configure the Time-Aware
Scheduler via tc-taprio offload
Caution: EXT Email
On Wed, Nov 13, 2019 at 03:45:08AM +0000, Po Liu wrote:
quoted
Hi Ivan,
quoted
-----Original Message-----
From: Ivan Khoronzhuk <redacted>
Sent: 2019年11月13日 5:10
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net;
linux- kernel@vger.kernel.org; netdev@vger.kernel.org;
vinicius.gomes@intel.com; Vladimir Oltean [off-list ref];
Alexandru Marginean [off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [v2,net-next, 1/2] enetc: Configure the Time-Aware
Scheduler via tc-taprio offload
Caution: EXT Email
Hello,
On Tue, Nov 12, 2019 at 08:42:49AM +0000, Po Liu wrote:
quoted
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
changes:
- introduce a local define CONFIG_FSL_ENETC_QOS to fix the various
configurations will result in link errors.
Since the CONFIG_NET_SCH_TAPRIO depends on many Qos configs. Not
to use it directly in driver. Add it to CONFIG_FSL_ENETC_QOS
depends
on list, so only CONFIG_NET_SCH_TAPRIO enabled, user can enable
this
tsn feature, or else, return not support.
drivers/net/ethernet/freescale/enetc/Kconfig | 10 ++
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 7 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
7 files changed, 300 insertions(+), 22 deletions(-) create mode
100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
[...]
quoted
@@ -1483,6 +1479,19 @@ int enetc_setup_tc(struct net_device *ndev,
Sorry didn't see v2, so i duplicate my question here:
This patch is for taprio offload, I see that mqprio is related and is
part of taprio offload configuration. But taprio offload has own mqprio
settings.
quoted
quoted
The taprio mqprio part is not offloaded with TC_SETUP_QDISC_MQPRIO.
So, a combination of mqprio and tario qdiscs used.
Could you please share the commands were used for your setup?
So, the TC_SETUP_QDISC_MQPRIO is really not required here, and mqprio qdisc
is not used. Then why is it here, should be placed in separate patch at least.
Taprio is not fully copy the mqprio but refer the mqprio feature. I don't think there is
Problem for them all list in driver. Some person may not use taprio at all.
But even the comb mqprio qdisc and taprio qdisc are used together then taprio
requires hw offload also. I'm Ok to add it later to taprio, and I'm asking about it
because I need it also, what ever way it could be added.
Not clear how you combined mqprio qdisc and taprio now to get it working
From this command:
tc qdisc replace dev eth0 parent root handle 100 taprio num_tc 8 map 0 1 2 3
4
5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 01 sched-
entry S 02
300000 flags 0x2
I can conclude that some default h/w mapping (one to one) were used and no
need to use mqprio qdisc, the command above is enough.
Is it true?
Then move it to spearate patch please as it's not taprio related yet.
As mentioned, to set the queue mapping it is require the data_type include the mqprio parameter.
So here hardware set it as default. Without the settting, taprio would not say it is implement the offload.
So I don’t think it is proper to seperate another patch.
quoted
quoted
And couple interesting questions about all of this:
- The taprio qdisc has to have mqprio settings, but if it's done with
mqprio then it just skipped (by reading tc class num).
- If no separate mqprio qdisc configuration then mqprio conf from
taprio is set, who should restore tc mappings when taprio qdisc is unloaded?
Maybe there is reason to implement TC_SETUP_QDISC_MQPRIO offload in
taprio since it's required feature?
[...]
quoted
quoted
quoted
+
+ /* Configure the (administrative) gate control list using the
+ * control BD descriptor.
+ */
+ gcl_config = &cbd.gcl_conf;
+
+ data_size = sizeof(struct tgs_gcl_data) + gcl_len *
+ sizeof(struct gce);
+
+ gcl_data = kzalloc(data_size, __GFP_DMA | GFP_KERNEL);
+ if (!gcl_data)
+ return -ENOMEM;
+
+ gce = (struct gce *)(gcl_data + 1);
+
+ /* Since no initial state config in taprio, set gates open as default.
+ */
tc-taprio and IEEE Qbv allows to change configuration in flight, so
that oper state is active till new admin start time. So, here comment
says it does initial state config, if in-flight feature is not
supported then error has to be returned instead of silently rewriting
configuration. But if it can be implemented then state should be
remembered/verified in order to not brake oper configuration?
quoted
I think this is ok as per standard. Also see this comment in
net/sched/sch_taprio.c:
From the code above (duplicate for convenience):
if (admin_conf->enable) {
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp & (~ENETC_QBV_TGE));
usleep_range(10, 20);
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp | ENETC_QBV_TGE);
} else {
enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET,
temp & (~ENETC_QBV_TGE));
return 0;
}
I see that's not true, as Simon noted, you have same command:
enetc_wr(&priv->si->hw, ENETC_QBV_PTGCR_OFFSET, temp &
(~ENETC_QBV_TGE));
before enabling and for disabling. I guess it's stop command, that is disable qbv.
So, before enabling new configuration with enetc_setup_tc(), the tario is
inited|cleared|reseted|rebooted|defaulted|offed but not updated. It
inited|cleared|reseted|rebooted|defaulted|means no
in-flight capabilities or they are ignored.
The Qbv spec do not show the disable before enable.
Here is hardware workaround to avoid the hardware run into unknow state.
JFI, it's possible to do first time:
tc qdisc replace dev eth0 parent root handle 100 taprio num_tc 8 map 0 1 2 3
4
5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 01 sched-
entry S 02
300000 flags 0x2
and then:
tc qdisc replace dev eth0 parent root handle 100 taprio base-time 01 sched-
entry S 02 200000 flags 0x2
Do it many times, but w/o mqprio configuration.
So, this function must return error if it cannot be done, as above commands
suppose that configuration can be updated in runtime, that is, set ADMIN cycle
while OPER cycle is still active for some time and not broken like it's done now.
If it can be achieved then no need to do enetc_wr(&priv->si->hw,
ENETC_QBV_PTGCR_OFFSET, temp & (~ENETC_QBV_TGE)); when admin_conf-
quoted
enable.
So or return error, or do it appropriately.
quoted
/* Until the schedule starts, all the queues are open */ I would
change the comment.
Ok, this is maximum number of schedules.
According to tc-taprio it's possible to set cycle period more then
schedules actually can consume. If cycle time is more, then last
gate's state can be kept till the end of cycle. But if last schedule
has it's own interval set then gates should be closed till the end of
cycle or no? if it has to be closed, then one more endl schedule
should be present closing gates at the end of list for the rest cycle time. Can
be implemented in h/w but just to be sure, how it's done in h/w?
quoted
quoted
There is already check the list len in up code.
if (admin_conf->num_entries > enetc_get_max_gcl_len(&priv->si->hw))
return -EINVAL;
gcl_len = admin_conf->num_entries;
I mean +1 schedule to finalize the cycle with closed gates if last schedule has
provided time interval. If I set couple schedules, with intervals, and cycle time
more then those schedules consume, then I suppose the gates closed for the
rest time of cycle, probably.
Example:
sched1 ----> shced2 ----> time w/o scheds -> cycle end
gate 1 gate 2 no gates
But if shced2 is last one then gate 2 is opened till the end of cycle.
So, to close gate one more shched is needed with closed gates to finalize it.
Or it's supposed that gate2 is opened till the end of cycle, How is it in you case.
Or this is can be provided by configuration from tc?
It's question not statement. Just though. Anyway i'll verify later it can be done
with tc and how it's done in sw version, just interesting how your h/w works.
What user command set the gate list would set into the hardware.
We have detail setting in the user manual which you can have it try.
From: Simon Horman <hidden> Date: 2019-11-12 09:41:31
On Mon, Nov 11, 2019 at 04:41:39AM +0000, Po Liu wrote:
quoted hunk
ENETC has a register PSPEED to indicate the link speed of hardware.
It is need to update accordingly. PSPEED field needs to be updated
with the port speed for QBV scheduling purposes. Or else there is
chance for gate slot not free by frame taking the MAC if PSPEED and
phy speed not match. So update PSPEED when link adjust. This is
implement by the adjust_link.
Signed-off-by: Po Liu <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Singed-off-by: Vladimir Oltean [off-list ref]
---
drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++--
drivers/net/ethernet/freescale/enetc/enetc.h | 7 ++++
.../net/ethernet/freescale/enetc/enetc_pf.c | 3 ++
.../net/ethernet/freescale/enetc/enetc_qos.c | 34 +++++++++++++++++++
4 files changed, 55 insertions(+), 2 deletions(-)
@@ -742,6 +742,9 @@ static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,ndev->priv_flags|=IFF_UNICAST_FLT;+if(si->hw_features&ENETC_SI_F_QBV)+priv->active_offloads|=ENETC_F_QBV;+/* pick up primary MAC address from SI */enetc_get_primary_mac_addr(&si->hw,ndev->dev_addr);}
From: kbuild test robot <hidden> Date: 2019-11-12 20:00:50
Hi Po,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc7 next-20191111]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Po-Liu/enetc-Configure-the-Time-Aware-Scheduler-via-tc-taprio-offload/20191112-193235
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ca22d6977b9b4ab0fd2e7909b57e32ba5b95046f
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>
All errors (new ones prefixed by >>):
-----Original Message-----
From: David Miller <redacted>
Sent: 2019年11月12日 13:51
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; vinicius.gomes@intel.com; Vladimir Oltean
[off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
tc-taprio offload
Caution: EXT Email
From: Po Liu <redacted>
Date: Mon, 11 Nov 2019 04:41:26 +0000
From: Simon Horman <hidden> Date: 2019-11-12 09:41:36
On Mon, Nov 11, 2019 at 04:41:26AM +0000, Po Liu wrote:
quoted hunk
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Singed-off-by: Vladimir Oltean [off-list ref]
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 2 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
6 files changed, 285 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
Perhaps BIT() is appropriate here.
The changes above to enetc_hw.h are not used until the following patch,
perhaps it would be better if they were part of that patch.
quoted hunk
+
#define ENETC_PSR 0x0004 /* RO */
#define ENETC_PSIPMR 0x0018
#define ENETC_PSIPMR_SET_UP(n) BIT(n) /* n = SI index */
@@ -440,22 +447,6 @@ union enetc_rx_bd { #define EMETC_MAC_ADDR_FILT_RES 3 /* # of reserved entries at the beginning */ #define ENETC_MAX_NUM_VFS 2-struct enetc_cbd {- union {- struct {- __le32 addr[2];- __le32 opt[4];- };- __le32 data[6];- };- __le16 index;- __le16 length;- u8 cmd;- u8 cls;- u8 _res;- u8 status_flags;-};- #define ENETC_CBD_FLAGS_SF BIT(7) /* short format */ #define ENETC_CBD_STATUS_MASK 0xf
I'm a little surprised to see host endian values in a structure
that appears to be written to hardware. Is this intentional?
Also, these fields do not seem to be used in this patch-set.
Is that also intentional?
Perhaps GENMASK() is appropriate here and elsewhere for generating masks.
+
+/* gate control list entry */
+struct gce {
+ u32 period;
Likewise, I'm a little surprised to see host-byte order data to
be written to HW. And below too. Though as I've noted below,
some of these values are used to store le32 data, so it seems
that the types are incorrect.
+ u8 gate;
+ u8 res[3];
+};
+
+/* tgs_gcl_conf address point to this data space */
+struct tgs_gcl_data {
+ u32 btl;
+ u32 bth;
+ u32 ct;
+ u32 cte;
+};
+
+/* class 5, command 1 */
+struct tgs_gcl_query {
+ u8 res[12];
+ union {
+ struct {
+ __le16 acl_len; /* admin list length */
+ __le16 ocl_len; /* operation list length */
+ };
+ struct {
+ u16 admin_list_len;
+ u16 oper_list_len;
Again, is it intentional that these are a) host-byte order and
b) unused?
+ };
+ };
+};
+
+/* tgs_gcl_query command response data format */
+struct tgs_gcl_resp {
+ u32 abtl; /* base time */
+ u32 abth;
+ u32 act; /* cycle time */
+ u32 acte; /* cycle time extend */
+ u32 cctl; /* config change time */
+ u32 ccth;
+ u32 obtl; /* operation base time */
+ u32 obth;
+ u32 oct; /* operation cycle time */
+ u32 octe; /* operation cycle time extend */
+ u32 ccel; /* config change error */
+ u32 cceh;
+};
+
+ gcl_data = kzalloc(data_size, __GFP_DMA | GFP_KERNEL);
+ if (!gcl_data)
+ return -ENOMEM;
+
+ gce = (struct gce *)(gcl_data + 1);
+
+ /* Since no initial state config in taprio, set gates open as default.
+ */
+ gcl_config->atc = 0xff;
+ gcl_config->acl_len = cpu_to_le16(gcl_len);
+
+ if (!admin_conf->base_time) {
+ gcl_data->btl =
+ cpu_to_le32(enetc_rd(&priv->si->hw, ENETC_SICTR0));
+ gcl_data->bth =
+ cpu_to_le32(enetc_rd(&priv->si->hw, ENETC_SICTR1));
+ } else {
+ gcl_data->btl =
+ cpu_to_le32(lower_32_bits(admin_conf->base_time));
+ gcl_data->bth =
+ cpu_to_le32(upper_32_bits(admin_conf->base_time));
+ }
It looks like the types of the btl and bth fields are u32.
Perhaps they should be le32?
Please consider running sparse over this code to check for any endian
problems.
Gate is a u8 followed by 3 reserved bytes.
Perhaps there needs to be some bounds checking on
the value stored there given that the source is 32bits wide.
Also, its not clear to me that the above logic, which I assume
takes the last significant byte of a 32bit value, works on
big endian systems as the 32bit value is always little endian.
-----Original Message-----
From: Simon Horman <redacted>
Sent: 2019年11月12日 17:41
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; davem@davemloft.net; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; vinicius.gomes@intel.com;
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
tc-taprio offload
Caution: EXT Email
On Mon, Nov 11, 2019 at 04:41:26AM +0000, Po Liu wrote:
quoted
ENETC supports in hardware for time-based egress shaping according to
IEEE 802.1Qbv. This patch implement the Qbv enablement by the hardware
offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Singed-off-by: Vladimir Oltean [off-list ref]
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 2 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
6 files changed, 285 insertions(+), 22 deletions(-) create mode
100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
Perhaps GENMASK() is appropriate here and elsewhere for generating masks.
Will remove these define in this patch.
quoted
+
+/* gate control list entry */
+struct gce {
+ u32 period;
Likewise, I'm a little surprised to see host-byte order data to be written to HW.
And below too. Though as I've noted below, some of these values are used to
store le32 data, so it seems that the types are incorrect
Ok. change to le32.
quoted
+ u8 gate;
+ u8 res[3];
+};
+
+/* tgs_gcl_conf address point to this data space */ struct
+tgs_gcl_data {
+ u32 btl;
+ u32 bth;
+ u32 ct;
+ u32 cte;
+};
+
Gate is a u8 followed by 3 reserved bytes.
Perhaps there needs to be some bounds checking on
the value stored there given that the source is 32bits wide.
Also, its not clear to me that the above logic, which I assume
takes the last significant byte of a 32bit value, works on
big endian systems as the 32bit value is always little endian.
temp_entry->gate_mask is 32bit for wide possible input. Here change to hardware set 8bit wide.
Can it just be like:
temp_gce->gate = (u8) temp_entry->gate_mask;
Given that u* types are used in this structure I think le16 would be more
appropriate than __le16.
Here keep the same code style of this .h file. I think it is better to have
another patch to fix them all. Do you agree?
I don't see why "le16" would be more appropriate than "__le16" in this context.
The "__leXX" types are widely used in kernel drivers and not only, to annotate the
endianess of the hardware. These are generic types defined din "include/uapi/linux/types.h".
Whereas "leXX" are defined in "fs/ntfs/types.h", and there's no usage of these types
in other h/w device drivers (I didn't find any). Am I missing anything?
-Claudiu
Given that u* types are used in this structure I think le16 would be more
appropriate than __le16.
Here keep the same code style of this .h file. I think it is better to have
another patch to fix them all. Do you agree?
I don't see why "le16" would be more appropriate than "__le16" in this context.
The "__leXX" types are widely used in kernel drivers and not only, to annotate the
endianess of the hardware. These are generic types defined din "include/uapi/linux/types.h".
Whereas "leXX" are defined in "fs/ntfs/types.h", and there's no usage of these types
in other h/w device drivers (I didn't find any). Am I missing anything?
My point is a cosmetic one:
I think that __u8 goes with __le16, while u8 goes with le16.
I'm a little surprised to see host endian values in a structure that appears to be
written to hardware. Is this intentional?
Will remove.
If the HW defines these fields then I think its fine to leave them,
though with the correct byte-order.
I was more asking if it is intentional that the value for these
fields, when sent to the HW, is always zero in the context of this
patch-set. Likewise elsewhere.
...
Gate is a u8 followed by 3 reserved bytes.
Perhaps there needs to be some bounds checking on
the value stored there given that the source is 32bits wide.
Also, its not clear to me that the above logic, which I assume
takes the last significant byte of a 32bit value, works on
big endian systems as the 32bit value is always little endian.
temp_entry->gate_mask is 32bit for wide possible input. Here change to hardware set 8bit wide.
Can it just be like:
temp_gce->gate = (u8) temp_entry->gate_mask;
I think that would be better.
Perhaps its best to also mask out the unwanted bits.
...
From: David Miller <davem@davemloft.net> Date: 2019-11-12 18:59:02
Oops, I didn't see this feedback because v2 had been posted.
I'll revert that now.
Please address Simon's feedback on these two patches, and then post a v3,
thank you.
From: David Miller <davem@davemloft.net> Date: 2019-11-12 18:59:43
From: David Miller <davem@davemloft.net>
Date: Tue, 12 Nov 2019 10:58:59 -0800 (PST)
Oops, I didn't see this feedback because v2 had been posted.
I'll revert that now.
Please address Simon's feedback on these two patches, and then post a v3,
thank you.
Also, v2 doesn't even compile :-(
In file included from drivers/net/ethernet/freescale/enetc/enetc.h:14,
from drivers/net/ethernet/freescale/enetc/enetc_qos.c:4:
drivers/net/ethernet/freescale/enetc/enetc_qos.c: In function ‘enetc_setup_tc_taprio’:
drivers/net/ethernet/freescale/enetc/enetc_hw.h:308:32: warning: ‘temp’ may be used uninitialized in this function [-Wmaybe-uninitialized]
#define enetc_wr_reg(reg, val) iowrite32((val), (reg))
^~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc_qos.c:59:6: note: ‘temp’ was declared here
u32 temp;
^~~~
ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-enetc-vf.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1282: modules] Error 2
-----Original Message-----
From: David Miller <davem@davemloft.net>
Sent: 2019年11月13日 3:00
To: simon.horman@netronome.com
Cc: Po Liu <redacted>; Claudiu Manoil <claudiu.manoil@nxp.com>;
linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
vinicius.gomes@intel.com; Vladimir Oltean [off-list ref];
Alexandru Marginean [off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
tc-taprio offload
Caution: EXT Email
From: David Miller <davem@davemloft.net>
Date: Tue, 12 Nov 2019 10:58:59 -0800 (PST)
quoted
Oops, I didn't see this feedback because v2 had been posted.
I'll revert that now.
Please address Simon's feedback on these two patches, and then post a
v3, thank you.
Also, v2 doesn't even compile :-(
In file included from drivers/net/ethernet/freescale/enetc/enetc.h:14,
from drivers/net/ethernet/freescale/enetc/enetc_qos.c:4:
drivers/net/ethernet/freescale/enetc/enetc_qos.c: In function
ʽenetc_setup_tc_taprioʼ:
drivers/net/ethernet/freescale/enetc/enetc_hw.h:308:32: warning: ʽtempʼ may
be used uninitialized in this function [-Wmaybe-uninitialized] #define
enetc_wr_reg(reg, val) iowrite32((val), (reg))
^~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc_qos.c:59:6: note: ʽtempʼ was
declared here
From: kbuild test robot <hidden> Date: 2019-11-12 12:31:25
Hi Po,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on v5.4-rc7 next-20191111]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Po-Liu/enetc-Configure-the-Time-Aware-Scheduler-via-tc-taprio-offload/20191112-193235
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ca22d6977b9b4ab0fd2e7909b57e32ba5b95046f
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
In file included from arch/s390/include/asm/io.h:76:0,
from include/linux/io.h:13,
from include/linux/pci.h:39,
from drivers/net/ethernet/freescale/enetc/enetc.h:5,
from drivers/net/ethernet/freescale/enetc/enetc_qos.c:4:
drivers/net/ethernet/freescale/enetc/enetc_qos.c: In function 'enetc_setup_tc_taprio':
quoted
include/asm-generic/io.h:735:19: warning: 'temp' may be used uninitialized in this function [-Wmaybe-uninitialized]
#define iowrite32 iowrite32
^~~~~~~~~
drivers/net/ethernet/freescale/enetc/enetc_qos.c:25:6: note: 'temp' was declared here
u32 temp;
^~~~
--
In file included from arch/s390/include/asm/io.h:76:0,
from include/linux/io.h:13,
from include/linux/pci.h:39,
from drivers/net//ethernet/freescale/enetc/enetc.h:5,
from drivers/net//ethernet/freescale/enetc/enetc_qos.c:4:
drivers/net//ethernet/freescale/enetc/enetc_qos.c: In function 'enetc_setup_tc_taprio':
quoted
include/asm-generic/io.h:735:19: warning: 'temp' may be used uninitialized in this function [-Wmaybe-uninitialized]
#define iowrite32 iowrite32
^~~~~~~~~
drivers/net//ethernet/freescale/enetc/enetc_qos.c:25:6: note: 'temp' was declared here
u32 temp;
^~~~
vim +/temp +735 include/asm-generic/io.h
9216efafc52ff9 Thierry Reding 2014-10-01 733
9216efafc52ff9 Thierry Reding 2014-10-01 734 #ifndef iowrite32
9216efafc52ff9 Thierry Reding 2014-10-01 @735 #define iowrite32 iowrite32
9216efafc52ff9 Thierry Reding 2014-10-01 736 static inline void iowrite32(u32 value, volatile void __iomem *addr)
9216efafc52ff9 Thierry Reding 2014-10-01 737 {
9216efafc52ff9 Thierry Reding 2014-10-01 738 writel(value, addr);
9216efafc52ff9 Thierry Reding 2014-10-01 739 }
9216efafc52ff9 Thierry Reding 2014-10-01 740 #endif
9216efafc52ff9 Thierry Reding 2014-10-01 741
:::::: The code at line 735 was first introduced by commit
:::::: 9216efafc52ff99e9351ef60de5fcafc2bc8adb6 asm-generic/io.h: Reconcile I/O accessor overrides
:::::: TO: Thierry Reding [off-list ref]
:::::: CC: Thierry Reding [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
From: Ivan Khoronzhuk <hidden> Date: 2019-11-12 16:03:08
On Mon, Nov 11, 2019 at 04:41:26AM +0000, Po Liu wrote:
quoted hunk
ENETC supports in hardware for time-based egress shaping according
to IEEE 802.1Qbv. This patch implement the Qbv enablement by the
hardware offload method qdisc tc-taprio method.
Also update cbdr writeback to up level since control bd ring may
writeback data to control bd ring.
Signed-off-by: Po Liu <redacted>
Singed-off-by: Vladimir Oltean [off-list ref]
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/freescale/enetc/Makefile | 1 +
drivers/net/ethernet/freescale/enetc/enetc.c | 19 ++-
drivers/net/ethernet/freescale/enetc/enetc.h | 2 +
.../net/ethernet/freescale/enetc/enetc_cbdr.c | 5 +-
.../net/ethernet/freescale/enetc/enetc_hw.h | 150 ++++++++++++++++--
.../net/ethernet/freescale/enetc/enetc_qos.c | 130 +++++++++++++++
6 files changed, 285 insertions(+), 22 deletions(-)
create mode 100644 drivers/net/ethernet/freescale/enetc/enetc_qos.c
This patch is for taprio offload, I see that mqprio is related and is part of
taprio offload configuration. But taprio offload has own mqprio settings.
The taprio mqprio part is not offloaded with TC_SETUP_QDISC_MQPRIO.
So, a combination of mqprio and tario qdiscs used.
Could you please share the commands were used for your setup?
And couple interesting questions about all of this:
- The taprio qdisc has to have mqprio settings, but if it's done with
mqprio then it just skipped (by reading tc class num).
- If no separate mqprio qdisc configuration then mqprio conf from taprio
is set, who should restore tc mappings when taprio qdisc is unloaded?
Maybe there is reason to implement TC_SETUP_QDISC_MQPRIO offload in taprio
since it's required feature?
Would be better to move changes for mqprio in separate patch with explanation.
@@ -0,0 +1,130 @@+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)+/* Copyright 2019 NXP */++#include"enetc.h"++#include<net/pkt_sched.h>++staticu16enetc_get_max_gcl_len(structenetc_hw*hw)+{+returnenetc_rd(hw,ENETC_QBV_PTGCAPR_OFFSET)+&ENETC_QBV_MAX_GCL_LEN_MASK;+}++staticintenetc_setup_taprio(structnet_device*ndev,+structtc_taprio_qopt_offload*admin_conf)+{+structenetc_ndev_priv*priv=netdev_priv(ndev);+structenetc_cbdcbd={.cmd=0};+structtgs_gcl_conf*gcl_config;+structtgs_gcl_data*gcl_data;+structgce*gce;+dma_addr_tdma;+u16data_size;+u16gcl_len;+u32temp;+inti;++gcl_len=admin_conf->num_entries;+if(gcl_len>enetc_get_max_gcl_len(&priv->si->hw))+return-EINVAL;++if(admin_conf->enable){+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+usleep_range(10,20);+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp|ENETC_QBV_TGE);+}else{+enetc_wr(&priv->si->hw,+ENETC_QBV_PTGCR_OFFSET,+temp&(~ENETC_QBV_TGE));+return0;+}++/* Configure the (administrative) gate control list using the+*controlBDdescriptor.+*/+gcl_config=&cbd.gcl_conf;++data_size=sizeof(structtgs_gcl_data)+gcl_len*sizeof(structgce);++gcl_data=kzalloc(data_size,__GFP_DMA|GFP_KERNEL);+if(!gcl_data)+return-ENOMEM;++gce=(structgce*)(gcl_data+1);++/* Since no initial state config in taprio, set gates open as default.+*/+gcl_config->atc=0xff;+gcl_config->acl_len=cpu_to_le16(gcl_len);++if(!admin_conf->base_time){+gcl_data->btl=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR0));+gcl_data->bth=+cpu_to_le32(enetc_rd(&priv->si->hw,ENETC_SICTR1));+}else{+gcl_data->btl=+cpu_to_le32(lower_32_bits(admin_conf->base_time));+gcl_data->bth=+cpu_to_le32(upper_32_bits(admin_conf->base_time));+}++gcl_data->ct=cpu_to_le32(admin_conf->cycle_time);+gcl_data->cte=cpu_to_le32(admin_conf->cycle_time_extension);++for(i=0;i<gcl_len;i++){+structtc_taprio_sched_entry*temp_entry;+structgce*temp_gce=gce+i;++temp_entry=&admin_conf->entries[i];++temp_gce->gate=cpu_to_le32(temp_entry->gate_mask);+temp_gce->period=cpu_to_le32(temp_entry->interval);+}++cbd.length=cpu_to_le16(data_size);+cbd.status_flags=0;++dma=dma_map_single(&priv->si->pdev->dev,gcl_data,+data_size,DMA_TO_DEVICE);+if(dma_mapping_error(&priv->si->pdev->dev,dma)){+netdev_err(priv->si->ndev,"DMA mapping failed!\n");+kfree(gcl_data);+return-ENOMEM;+}++cbd.addr[0]=lower_32_bits(dma);+cbd.addr[1]=upper_32_bits(dma);+cbd.cls=BDCR_CMD_PORT_GCL;++/* Updated by ENETC on completion of the configuration+*command.Azerovalueindicatessuccess.+*/+cbd.status_flags=0;++enetc_send_cmd(priv->si,&cbd);++dma_unmap_single(&priv->si->pdev->dev,dma,data_size,DMA_TO_DEVICE);+kfree(gcl_data);++return0;+}++intenetc_setup_tc_taprio(structnet_device*ndev,void*type_data)+{+structtc_taprio_qopt_offload*taprio=type_data;+structenetc_ndev_priv*priv=netdev_priv(ndev);+inti;++for(i=0;i<priv->num_tx_rings;i++)+enetc_set_bdr_prio(&priv->si->hw,+priv->tx_ring[i]->index,+taprio->enable?i:0);++returnenetc_setup_taprio(ndev,taprio);+}
From: kbuild test robot <hidden> Date: 2019-11-12 22:58:39
Hi Po,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on v5.4-rc7 next-20191111]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Po-Liu/enetc-Configure-the-Time-Aware-Scheduler-via-tc-taprio-offload/20191112-193235
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ca22d6977b9b4ab0fd2e7909b57e32ba5b95046f
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-29-g781bc5d-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>
sparse warnings: (new ones prefixed by >>)
quoted
drivers/net/ethernet/freescale/enetc/enetc.c:1430:5: sparse: sparse: symbol 'enetc_setup_tc_mqprio' was not declared. Should it be static?
--
quoted
drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] btl @@ got restrunsigned int [usertype] btl @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse: expected unsigned int [usertype] btl
drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse: got restricted __le32 [usertype]
drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] bth @@ got restrunsigned int [usertype] bth @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse: expected unsigned int [usertype] bth
drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse: got restricted __le32 [usertype]
drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] btl @@ got restrunsigned int [usertype] btl @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse: expected unsigned int [usertype] btl
drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse: got restricted __le32 [usertype]
drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] bth @@ got restrunsigned int [usertype] bth @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse: expected unsigned int [usertype] bth
drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse: got restricted __le32 [usertype]
quoted
drivers/net/ethernet/freescale/enetc/enetc_qos.c:77:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] ct @@ got restrunsigned int [usertype] ct @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:77:22: sparse: expected unsigned int [usertype] ct
drivers/net/ethernet/freescale/enetc/enetc_qos.c:78:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] cte @@ got restrunsigned int [usertype] cte @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:78:23: sparse: expected unsigned int [usertype] cte
drivers/net/ethernet/freescale/enetc/enetc_qos.c:87:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] period @@ got restrunsigned int [usertype] period @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:87:34: sparse: expected unsigned int [usertype] period