RE: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via tc-taprio offload

Hi David,


Br,
Po Liu

-----Original Message-----
From: David Miller <redacted>
Sent: 2019年11月12日 13:51
To: Po Liu <redacted>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; vinicius.gomes@intel.com; Vladimir Oltean
[off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]
Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
tc-taprio offload

Caution: EXT Email

From: Po Liu <redacted>
Date: Mon, 11 Nov 2019 04:41:26 +0000

quoted

+fsl-enetc-$(CONFIG_NET_SCH_TAPRIO) += enetc_qos.o

Code is Kconfig guarded.

quoted

+     case TC_SETUP_QDISC_TAPRIO:
+             return enetc_setup_tc_taprio(ndev, type_data);

Yet invoked unconditionally.

I can see just by reading your code that various configurations will result in link
errors.

I get it. Thanks!

 ...

quoted

+int enetc_setup_tc_taprio(struct net_device *ndev, void *type_data) {
+     struct tc_taprio_qopt_offload *taprio = type_data;
+     struct enetc_ndev_priv *priv = netdev_priv(ndev);
+     int i;
+
+     for (i = 0; i < priv->num_tx_rings; i++)
+             enetc_set_bdr_prio(&priv->si->hw,
+                                priv->tx_ring[i]->index,
+                                taprio->enable ? i : 0);
+
+     return enetc_setup_taprio(ndev, taprio); }
--
2.17.1