Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via tc-taprio offload

Hi Po,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on v5.4-rc7 next-20191111]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Po-Liu/enetc-Configure-the-Time-Aware-Scheduler-via-tc-taprio-offload/20191112-193235
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ca22d6977b9b4ab0fd2e7909b57e32ba5b95046f
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-29-g781bc5d-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>


sparse warnings: (new ones prefixed by >>)

quoted

drivers/net/ethernet/freescale/enetc/enetc.c:1430:5: sparse: sparse: symbol 'enetc_setup_tc_mqprio' was not declared. Should it be static?

--

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] btl @@    got restrunsigned int [usertype] btl @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse:    expected unsigned int [usertype] btl
drivers/net/ethernet/freescale/enetc/enetc_qos.c:66:31: sparse:    got restricted __le32 [usertype]
drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] bth @@    got restrunsigned int [usertype] bth @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse:    expected unsigned int [usertype] bth

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:68:31: sparse:    got restricted __le32 [usertype]
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] btl @@    got restrunsigned int [usertype] btl @@
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse:    expected unsigned int [usertype] btl
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:71:31: sparse:    got restricted __le32 [usertype]
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] bth @@    got restrunsigned int [usertype] bth @@
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse:    expected unsigned int [usertype] bth
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:73:31: sparse:    got restricted __le32 [usertype]

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:77:22: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] ct @@    got restrunsigned int [usertype] ct @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:77:22: sparse:    expected unsigned int [usertype] ct

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:77:22: sparse:    got restricted __le32 [usertype]

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:78:23: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] cte @@    got restrunsigned int [usertype] cte @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:78:23: sparse:    expected unsigned int [usertype] cte

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:78:23: sparse:    got restricted __le32 [usertype]

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:86:32: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned char [usertype] gate @@    got restunsigned char [usertype] gate @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:86:32: sparse:    expected unsigned char [usertype] gate

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:86:32: sparse:    got restricted __le32 [usertype]

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:87:34: sparse: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [usertype] period @@    got restrunsigned int [usertype] period @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:87:34: sparse:    expected unsigned int [usertype] period

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:87:34: sparse:    got restricted __le32 [usertype]

quoted

drivers/net/ethernet/freescale/enetc/enetc_qos.c:101:21: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __le32 @@    got unsignerestricted __le32 @@
drivers/net/ethernet/freescale/enetc/enetc_qos.c:101:21: sparse:    expected restricted __le32
drivers/net/ethernet/freescale/enetc/enetc_qos.c:101:21: sparse:    got unsigned int [usertype]

   drivers/net/ethernet/freescale/enetc/enetc_qos.c:102:21: sparse: sparse: incorrect type in assignment (different base types) @@    expected restricted __le32 @@    got unsignerestricted __le32 @@
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:102:21: sparse:    expected restricted __le32
   drivers/net/ethernet/freescale/enetc/enetc_qos.c:102:21: sparse:    got unsigned int [usertype]

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation