Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2019-07-30 23:39:56
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2019-07-30 23:39:56
On Mon, 22 Jul 2019 14:40:19 -0700 Shannon Nelson [off-list ref] wrote:
+
+static void ionic_lif_set_netdev_info(struct lif *lif)
+{
+ struct ionic_admin_ctx ctx = {
+ .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work),
+ .cmd.lif_setattr = {
+ .opcode = CMD_OPCODE_LIF_SETATTR,
+ .index = cpu_to_le16(lif->index),
+ .attr = IONIC_LIF_ATTR_NAME,
+ },
+ };
+
+ strlcpy(ctx.cmd.lif_setattr.name, lif->netdev->name,
+ sizeof(ctx.cmd.lif_setattr.name));
+
+ dev_info(lif->ionic->dev, "NETDEV_CHANGENAME %s %s\n",
+ lif->name, ctx.cmd.lif_setattr.name);
+There is already a kernel message for this. Repeating the same thing in the driver is redundant.