On 7/23/19 4:20 PM, Saeed Mahameed wrote:

On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote:

quoted

quoted

@@ -607,6 +947,8 @@ static void ionic_lif_free(struct lif *lif)
  	ionic_qcqs_free(lif);
  	ionic_lif_reset(lif);
  

I don't think you want deferred.work running while reset is executing..
cancel_work_sync should happen as early as you close the netdevice.

Given the current implementation, it doesn't actually hurt anything, but 
yes it makes sense to move it up in the sequence.

I assume ionic_lif_reset will flush all configurations and you don't
need to cleanup anything manually?  or any data structure stored in
driver ?

Most of the driver data structure cleaning has happened in 
ionic_lif_deinit() before getting here.

sln