On 7/24/19 5:17 PM, Saeed Mahameed wrote:

On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote:

quoted

Add in the basic ethtool callbacks for device information
and control.

Signed-off-by: Shannon Nelson <redacted>
---

quoted

+
+	while (test_and_set_bit(LIF_QUEUE_RESET, lif->state))
+		usleep_range(200, 400);
+

I see this is recurring a lot in the driver, i suggest to have a helper
function (wait_pending_reset_timeout) and make it return with timeout
errno after a reasonable amount of time, especially on user context
flows.

Sure.
sln