[PATCH v4 net-next 00/19] Add ionic driver · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 01/19] ionic: Add basic framework for IONIC Network device driver · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 03/19] ionic: Add port management commands · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-23
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-23
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-24
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · David Miller <davem@davemloft.net> · 2019-07-24
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Saeed Mahameed <hidden> · 2019-07-23
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-24
Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands · Shannon Nelson <hidden> · 2019-07-24
[PATCH v4 net-next 04/19] ionic: Add basic lif support · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support · Saeed Mahameed <hidden> · 2019-07-24
Re: [PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support · Shannon Nelson <hidden> · 2019-07-30
[PATCH v4 net-next 08/19] ionic: Add notifyq support · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 08/19] ionic: Add notifyq support · Saeed Mahameed <hidden> · 2019-07-24
Re: [PATCH v4 net-next 08/19] ionic: Add notifyq support · Shannon Nelson <hidden> · 2019-07-30
[PATCH v4 net-next 07/19] ionic: Add adminq action · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Shannon Nelson <hidden> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Saeed Mahameed <hidden> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Shannon Nelson <hidden> · 2019-07-24
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Shannon Nelson <hidden> · 2019-07-24
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Saeed Mahameed <hidden> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Saeed Mahameed <hidden> · 2019-07-23
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Shannon Nelson <hidden> · 2019-07-24
Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support · Saeed Mahameed <hidden> · 2019-07-24
[PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Shannon Nelson <hidden> · 2019-07-23
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Saeed Mahameed <hidden> · 2019-07-25
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Shannon Nelson <hidden> · 2019-07-30
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Andrew Lunn <andrew@lunn.ch> · 2019-07-25
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Andrew Lunn <andrew@lunn.ch> · 2019-07-25
Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support · Shannon Nelson <hidden> · 2019-07-30
[PATCH v4 net-next 15/19] ionic: Add netdev-event handling · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling · Saeed Mahameed <hidden> · 2019-07-25
Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling · Shannon Nelson <hidden> · 2019-07-30
Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling · Stephen Hemminger <stephen@networkplumber.org> · 2019-07-30
Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling · Shannon Nelson <hidden> · 2019-07-31
[PATCH v4 net-next 17/19] ionic: Add RSS support · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 16/19] ionic: Add driver stats · Shannon Nelson <hidden> · 2019-07-22
[PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling · Saeed Mahameed <hidden> · 2019-07-25
Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling · Shannon Nelson <hidden> · 2019-08-09
[PATCH v4 net-next 19/19] ionic: Add basic devlink interface · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 19/19] ionic: Add basic devlink interface · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 19/19] ionic: Add basic devlink interface · Shannon Nelson <hidden> · 2019-07-23
[PATCH v4 net-next 18/19] ionic: Add coalesce and other features · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features · Saeed Mahameed <hidden> · 2019-07-26
Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features · Shannon Nelson <hidden> · 2019-08-02
[PATCH v4 net-next 06/19] ionic: Add basic adminq support · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support · Shannon Nelson <hidden> · 2019-07-23
[PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats · Saeed Mahameed <hidden> · 2019-07-25
Re: [PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats · Shannon Nelson <hidden> · 2019-07-30
[PATCH v4 net-next 10/19] ionic: Add management of rx filters · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 10/19] ionic: Add management of rx filters · Saeed Mahameed <hidden> · 2019-07-24
[PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells · Shannon Nelson <hidden> · 2019-07-22
Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells · David Miller <davem@davemloft.net> · 2019-07-23
Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells · Shannon Nelson <hidden> · 2019-07-23

Re: [PATCH v4 net-next 19/19] ionic: Add basic devlink interface

From: Shannon Nelson <hidden>
Date: 2019-07-23 22:51:03

On 7/23/19 2:40 PM, David Miller wrote:

From: Shannon Nelson <redacted>
Date: Mon, 22 Jul 2019 14:40:23 -0700

quoted

+struct ionic *ionic_devlink_alloc(struct device *dev)
+{
+	struct devlink *dl;
+	struct ionic *ionic;

Reverse christmas tree please.

Yep, I missed this one.

Thanks for your review time.
sln

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help