Re: [PATCH V3 04/15] ARM: exynos: cleanup cppcheck shifting error

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2019-06-25 18:50:00
Also in
bpf, linux-omap, linux-samsung-soc, lkml
Reply to
Phong Tran, 2019-06-25
On Tue, Jun 25, 2019 at 11:03:45AM +0700, Phong Tran wrote:
There is error from cppcheck tool
"Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
change to use BIT() marco for improvement.

Signed-off-by: Phong Tran <redacted>
---
 arch/arm/mach-exynos/suspend.c | 2 +-
Thanks, applied with slightly different commit message. As Peter
pointed, there is no error because of GCC.  Usually we expect a reply to
comments on LKML...  and also you could take his hints and use them to
improve the commit msg to properly describe what is the problem.

Best regards,
Krzysztof
Thread (67 messages) 67 messages, 11 authors, last reply 2019-06-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help