Re: [PATCH V2 00/15] cleanup cppcheck signed shifting errors

From
Peter Zijlstra <peterz@infradead.org>
Date
2019-06-24 15:29:32
Also in
bpf, linux-omap, linux-samsung-soc, lkml
Reply to
Peter Zijlstra, 2019-06-24
On Mon, Jun 24, 2019 at 05:27:43PM +0200, Peter Zijlstra wrote:
On Mon, Jun 24, 2019 at 08:50:50PM +0700, Phong Tran wrote:
quoted
There are errors with cppcheck 

"Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
As I've already told you; your checker is bad. That is not in face
Bah, fact, typing hard.
undefined behaviour in the kernel.

That's not to say you shouldn't clean up the code, but don't give broken
checkout output as a reason.
Thread (67 messages) 67 messages, 11 authors, last reply 2019-06-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help