Re: [PATCH 04/15] ARM: exynos: cleanup cppcheck shifting error

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2019-06-23 19:13:01
Also in
bpf, linux-omap, linux-samsung-soc, lkml
Reply to
Phong Tran, 2019-06-23
On Sun, 23 Jun 2019 at 17:14, Phong Tran [off-list ref] wrote:
[arch/arm/mach-exynos/suspend.c:288]: (error) Shifting signed 32-bit
value by 31 bits is undefined behaviour

Signed-off-by: Phong Tran <redacted>
---
 arch/arm/mach-exynos/suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Let's switch to BIT macro. It will solve the problem and is preferred
way of coding.

Best regards,
Krzysztof
Thread (67 messages) 67 messages, 11 authors, last reply 2019-06-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help