Re: [PATCH V2 08/15] ARM: mmp: cleanup cppcheck shifting errors

From
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date
2019-06-24 13:59:58
Also in
bpf, linux-omap, linux-samsung-soc, lkml
Reply to
Phong Tran, 2019-06-24
On Mon, Jun 24, 2019 at 08:50:58PM +0700, Phong Tran wrote:
quoted hunk ↗ jump to hunk
 #define MPMU_PLL2_CTRL1				MPMU_REG(0x0414)
 #define MPMU_CGR_PJ				MPMU_REG(0x1024)
 #define MPMU_WUCRM_PJ				MPMU_REG(0x104c)
-#define MPMU_WUCRM_PJ_WAKEUP(x)			(1 << (x))
-#define MPMU_WUCRM_PJ_RTC_ALARM			(1 << 17)
+#define MPMU_WUCRM_PJ_WAKEUP(x)			BIT((x))
Extra parens not required.
+#define MPMU_AWUCRM_WAKEUP(x)			BIT(((x) & 0x7))
Ditto.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Thread (67 messages) 67 messages, 11 authors, last reply 2019-06-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help