Thread (48 messages) flat view 48 messages, 12 authors, 2017-12-07

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-12-06 08:32:20
Also in: lkml

Hi Linus,

On Wed, Dec 6, 2017 at 2:59 AM, Linus Torvalds
[off-list ref] wrote:
On Tue, Dec 5, 2017 at 5:36 PM, Sergey Senozhatsky
[off-list ref] wrote:
quoted
I see some %p-s being used in _supposedly_ important output,
like arch/x86/mm/fault.c

show_fault_oops(struct pt_regs *regs, unsigned long error_code,
                unsigned long address)
...
        printk(KERN_CONT " at %p\n", (void *) address);
        printk(KERN_ALERT "IP: %pS\n", (void *)regs->ip);
So %pS isn't %p, and shows the symbolic name.
If the symbolic name is available.
Else it prints the non-hashed pointer value (FTR).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help