Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks

Mon, Nov 13, 2017 at 09:05:26AM CET, jakub.kicinski@netronome.com wrote:

On Mon, 13 Nov 2017 08:56:58 +0100, Jiri Pirko wrote:

quoted

Mon, Nov 13, 2017 at 08:54:52AM CET, jakub.kicinski@netronome.com wrote:

quoted

On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote:  

quoted

diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c
index 5ecc38f..ee89efc 100644
--- a/net/sched/sch_ingress.c
+++ b/net/sched/sch_ingress.c

@@ -60,6 +60,29 @@ static void clsact_chain_head_change(struct tcf_proto *tp_head, void *priv)
 	struct mini_Qdisc_pair *miniqp = priv;
 
 	mini_qdisc_pair_swap(miniqp, tp_head);
+};
+
+static const struct nla_policy ingress_policy[TCA_CLSACT_MAX + 1] = {
+	[TCA_CLSACT_INGRESS_BLOCK]	= { .type = NLA_U32 },
+};
+
+static int ingress_parse_opt(struct nlattr *opt, u32 *p_ingress_block_index)  

nit: why the p_ prefix on all the pointers?  

Just to diferenciate:
u32 *ingress_block_index
and
u32 ingress_block_index

But why?  There isn't a single ingress_block_index in this patch.
Looks like Hungarian notation.

Will change that.