Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote:

Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicinski@netronome.com wrote:

quoted

On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote:  

quoted

From: Jiri Pirko <redacted>

In order to remove tp->q usage in cls_bpf, the offload->netdev check
needs to be moved to individual drivers as only they will have access
to appropriate struct net_device.

Signed-off-by: Jiri Pirko <redacted>  

This seems not entirely correct and it adds unnecessary code.  I think  

What is not correct?

From quick reading it looks like you will allow to install the
dev-specific filter without skip_sw flag.  You haven't fixed what
your previous series broke in cls_bpf offload model and now you 
break it even further.

quoted

the XDP and cls_bpf handling could be unified, making way for binding
the same program to multiple ports of the same device.  Would you mind
waiting a day for me to send corrections to BPF offload?  

Well I'm trying to get this in before net-next closes...

Right, and I'm surprised by that.  I'd hope you'll understand my caution
here given recent history.