Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

Mon, Nov 13, 2017 at 09:03:34AM CET, jakub.kicinski@netronome.com wrote:

On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote:

quoted

Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicinski@netronome.com wrote:

quoted

On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote:  

quoted

From: Jiri Pirko <redacted>

Couple of classifiers call netif_keep_dst directly on q->dev. That is
not possible to do directly for shared blocke where multiple qdiscs are
owning the block. So introduce a infrastructure to keep track of the
block owners in list and use this list to implement block variant of
netif_keep_dst.

Signed-off-by: Jiri Pirko <redacted>  

Could you use the list you add here to check the ethtool tc offload
flag? :)  

It is a list of qdisc sub parts. Not a list of netdevs

Hm.  OK, I won't pretend I understand the TC code in detail, I thought
that would give you all netdevs, but possibly duplicated.

Yeah, eventually you can get it. But still, it is unusable to check the
offload flag cause it has no relation with the block cbs.