Thread (31 messages) flat view 31 messages, 3 authors, 2017-11-18

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-11-13 06:25:40

Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicinski@netronome.com wrote:
On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote:
quoted
From: Jiri Pirko <redacted>

In order to remove tp->q usage in cls_bpf, the offload->netdev check
needs to be moved to individual drivers as only they will have access
to appropriate struct net_device.

Signed-off-by: Jiri Pirko <redacted>
This seems not entirely correct and it adds unnecessary code.  I think
What is not correct?

the XDP and cls_bpf handling could be unified, making way for binding
the same program to multiple ports of the same device.  Would you mind
waiting a day for me to send corrections to BPF offload?
Well I'm trying to get this in before net-next closes...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help