Thread (14 messages) 14 messages, 5 authors, 2016-10-08

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

From: Cong Wang <hidden>
Date: 2016-10-07 00:45:03

On Thu, Oct 6, 2016 at 12:38 PM, Eric Dumazet [off-list ref] wrote:
And another quick grep shows that out of 142 drivers, only one [1] of
them (incorrectly) checks netif_receive_skb() return value.
act_mirred is not a driver, apparently.

Real question is more like : what is the impact of propagating an error
at this point ?
_If_ we are going to just propagate the error like egress, then
the difference is m->tcf_action (PIPE or STOLEN) vs TC_ACT_SHOT.
And this error code is propagated from tcf_action_exec() up to
qdisc layer...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help