Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions
From: Cong Wang <hidden>
Date: 2016-10-03 19:45:21
On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani [off-list ref] wrote:
skb2->skb_iif = skb->dev->ifindex;
skb2->dev = dev;
- err = dev_queue_xmit(skb2);
+ if (tcf_mirred_act_direction(m_eaction) & AT_EGRESS)
+ err = dev_queue_xmit(skb2);
+ else
+ netif_receive_skb(skb2);Any reason why not check the return value here?